Australis: (write tests to) check that showInPrivateBrowsing and panel wide widget rearranging code are happy with each other.

RESOLVED INVALID

Status

()

RESOLVED INVALID
5 years ago
10 months ago

People

(Reporter: Gijs, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P5])

(Reporter)

Description

5 years ago
This is a somewhat theoretical problem, I suppose, as it's about the case where:
- Someone uses private browsing mixed with normal browsing, and opens the panel
- Someone uses widgets that specify showInPrivateBrowsing = false (is this the jetpack default? I hope not...)
- Someone adds those to the panel before any wide widgets

This will make things a bit sadfaces where the re-arranging code is concerned. I *think* the practical consequence right now is that wide items will get moved (possibly in multiple steps) to be before "public browsing only" widgets, as there will always be a window in which the wide widget is unhappy with the number of items that come before it (as this will be different in different windows).

I think this is OK, but I wanted to check that we're OK with this and/or want to do something else.
(Reporter)

Comment 1

5 years ago
I fixed this to only take 1 step in bug 885579. However, there are currently no tests for this, and my manual testing was also minimal. We should probably doublecheck this before we release, although we don't need to do that before we land on m-c as this is a pretty edgy edge-case.
Summary: Australis: showInPrivateBrowsing causes problems for panel wide widget rearranging code → Australis: (write tests to) check that showInPrivateBrowsing and panel wide widget rearranging code are happy with each other.
Whiteboard: [Australis:M?][Australis:P5] → [Australis:P5]
(Reporter)

Comment 2

10 months ago
We got rid of wide widgets and the old panel stuff.
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.