911089 - [CONTACTS] Facebook contacts appears in contact to export list to sim

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[rafael.marquez]

*Procedure
1. Open contacts app
2. Press settings button
3. Press export contacs button
4. Select "To sim" option

*Expected
The list of contacts available to export should not show the FB contacts 

*Actual
Facebook contacts appears in contact to export list to sim

Comment 1

[rafael.marquez]

Device: unagi
Branch: master
Gecko: b649729
Gaia: 12731a6


We have the same problem in the "export to vCard". We maintain this bug for two screens, but if necessary we can open a new bug.

Comment 2

[rafael.marquez]

Attachment: 2013-08-30-08-54-35.png

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

So this is one could require some thought.

It would be easy to filter out FB contacts after selection and before export, but thats not what is needed here.  Instead, we need to add an option to selectFromList() to say "show or hide FB contacts".

This is going to directly effect the code I'm working on now for bug 902873.  Also, how to show or hide the FB contacts during selection may require thought to do efficiently in a large list since we are sharing the DOM with the main list code.

Therefore I'd like to try to tackle this either as part of bug 902873 or after it lands.  I'm going to mark it dependent to track that.

Marking perf since I think it might be tricky to do efficiently in the list code.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Hi Ben,

totally make sense to make it part of bug 902873 to me.

Thanks a lot!

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

I still think this is perf related due to the way FB contacts are loaded and how the list is currently structured, but we defer to the communications team on whether to koi+ this or not.  Does that make sense to you guys?

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Hi Jose Manuel,

quick question, will it make sense that we allow to export the not enhanced contact?

In that case if a user adds extra information to a FB contact that will be stored in the mozcontact object isnt?

If we do that, we will have to deal with the problem of showing some contacts in the list that maybe have nothing to export (email, phone), but we already have to face that problem isnt?

Thanks!

Comment 7

[Jose Manuel Cantera]

+1 to that idea Francisco.

thanks

Comment 8

[Mike Lee [:mlee]]

David,

Please assign a Comms Apps engineer to this issue and make a call on koi+ or not.

Thanks,
Mike

Comment 9

[Jose Manuel Cantera]

I can work on this. As per agreements with FB of not disclosing data this must be koi+ .

Comment 10

[Mike Lee [:mlee]]

fxos-perf triage: koi+ per coment #9.

Comment 11

[Jose Manuel Cantera]

The FB Contacts appear on the list but the private information (email, phone) will be never exported, thus we can safely close this bug. 

Note 1: If the Contact is a FB Linked Contact then only the local information will be exported 
Note 2: This also applies to other exporters.