911125 - Remove ScriptAnalysis::printTypes and dump TypeScript's observed types instead

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

The bytecode types printed by INFERFLAGS=results are not very useful anymore since bug 804676, because in most cases we don't run analyzeTypes and hence don't print anything.

Although we no longer store pushed/popped types for every opcode, we can still dump the observed typesets (stored in TypeScript) and usually that's all we have to know.

I wrote a patch for this a while ago when I was looking into some JSIL perf problems.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

Removes ScriptAnalysis::printTypes, adds TypeScript::printTypes and calls it instead.

I also changed the inference spew to go to stderr, so that I could call JSString::dumpChars to dump the function name.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Patch

Comment 4

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a46d34be094

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8a46d34be094