Closed Bug 911139 Opened 7 years ago Closed 6 years ago

[Keyboard][V1.2] The currently enabled keyboard should have a check mark

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

VERIFIED FIXED
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: whsu, Assigned: dwi2)

References

Details

(Whiteboard: [FT:System-Platform], [Sprint:3])

Attachments

(3 files)

Attached image Need a check mark
* Description:
  This problem happens on v1.2 branch.
  After you long-press the global key to display the keyboard menu, the menu doesn't have a check mark to identify current keyboard layout.


* Reproduction steps:
  1. Launch the contact app
  2. Tap "+" to add a new contact.
  3. Tap the "Name" field
  4. Long press the Global key

* Expected result:
  After displaying the keyboard menu, the currently enabled keyboard should have a check mark.

* Actual result:
  No check mark to identify current keyboard layout

* Reproduction build:(Mozilla-Central)
  + Mercurial-Information
    - Gecko revision="416075f77249"
  + Git-information
    - Gaia revision="94c3dde50cb8da6e9d9ed137bfbf895f8699f8e7"(From Rudy's repository)
  + Gecko version: 26.0a1


Thanks!
blocking-b2g: --- → koi?
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Whiteboard: [FT:System-Platform], [Sprint:3]
Assignee: nobody → tzhuang
Attached file pull request
Attachment #806440 - Flags: review?(timdream)
Attachment #806440 - Flags: feedback?(gchen)
Hi tzhuang,
   Nice work, but something need to fix.
   According to the latest spec [1] page 10, 
   the check mark should be placed on the right side not left side.

   [1] https://mozilla.app.box.com/system/1/867862120/10261164859/1
Comment on attachment 806440 [details]
pull request

Overall looks good. Please set the f? and r? again once you move the checkbox to the right.
Attachment #806440 - Flags: review?(timdream)
Attachment #806440 - Flags: feedback?(gchen)
Attachment #806440 - Flags: review?(timdream)
Attachment #806440 - Flags: feedback?(gchen)
Comment on attachment 806440 [details]
pull request

Good for me.
great job!
Attachment #806440 - Flags: feedback?(gchen) → feedback+
Comment on attachment 806440 [details]
pull request

Thank you!
Attachment #806440 - Flags: review?(timdream) → review+
Depends on: 891673
blocking-b2g: koi? → koi+
Hi, all,

Thanks for your prompt help.
I verified this change.

* Test Build:
 - Gaia:     239332ad9e1cb26089be2be959eb22bc135da4f1
 - Gecko:    http://hg.mozilla.org/releases/mozilla-aurora/rev/caa6b17647c5
 - BuildID   20130926004001
 - Version   26.0a2

Attaching the screenshot.
Status: RESOLVED → VERIFIED
Attached image Check mark
You need to log in before you can comment on or make changes to this bug.