appini_header.py application.ini > application.ini.h: KeyError: 'Crash Reporter:serverurl'

RESOLVED FIXED in mozilla26

Status

RESOLVED FIXED
5 years ago
9 months ago

People

(Reporter: jbeich, Assigned: glandium)

Tracking

Trunk
mozilla26
x86_64
FreeBSD

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Build is broken for non-official builds:
_virtualenv/bin/python ../../build/appini_header.py ../dist/bin/application.ini > application.ini.h
Traceback (most recent call last):
  File "../../build/appini_header.py", line 51, in <module>
    main(sys.argv[1])
  File "../../build/appini_header.py", line 47, in main
    };''' % appdata
KeyError: 'Crash Reporter:serverurl'
gmake[5]: *** [application.ini.h] Error 1
(Reporter)

Updated

5 years ago
Blocks: 717538
(Reporter)

Comment 1

5 years ago
Created attachment 797827 [details] [diff] [review]
dummy workaround

r- if fixing appini_header.py is preferable
Attachment #797827 - Flags: review?(mh+mozilla)
(Assignee)

Comment 3

5 years ago
Created attachment 798089 [details] [diff] [review]
Better handle missing variables in application.ini when creating the corresponding header
Attachment #798089 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Updated

5 years ago
Attachment #797827 - Flags: review?(mh+mozilla) → review-

Updated

5 years ago
Attachment #798089 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/c59d6e7fdee5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.