Change "editor" and "preview" header text from blue to grey

RESOLVED WONTFIX

Status

Webmaker
Thimble
RESOLVED WONTFIX
5 years ago
3 years ago

People

(Reporter: cassiemc, Assigned: maronin)

Tracking

Details

(Whiteboard: frontend, navigation, uxdesign)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We've seen lots of users try to click on these titles thinking they are links. It seems like a simple quick fix to change them from blue to grey. Here's a screenshot: https://docs.google.com/file/d/0BzfN9sXlOXt1VmlkT1ZoUVhzTEE/edit?usp=sharing

(there are a few other changes in that screenshot, but just focus on the Editor and Preview titles for now)
(Assignee)

Comment 1

5 years ago
This seems like a very easy and minor fix. Mind if I take this issue?
Thanks Mark, go for it.  If you need any help, feel free to ask in #webmaker on moznet irc, or here.  Welcome to Webmaker dev!
Assignee: nobody → steroidcat
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Well, that was easy! Link to the pull request and details below. 

https://github.com/mozilla/thimble.webmaker.org/pull/247

Comment 4

5 years ago
Mark: you still need to pick someone to do the review for you on the attachment: click on the details, and then for "review" pick the "?" from the pulldown menu, and then fill in either a full email, or easier, type that person's :name (cassie's is :cassiemc, dave's is :humph, etc) and bugzilla will find the correct email for you
(Assignee)

Updated

5 years ago
QA Contact: cassie
(Assignee)

Updated

5 years ago
QA Contact: cassie
(Assignee)

Comment 5

5 years ago
Created attachment 814178 [details] [review]
Minor fix for the font color for the preview and editor text in Thimble.
Attachment #814178 - Flags: review?(cassie)
Comment on attachment 814178 [details] [review]
Minor fix for the font color for the preview and editor text in Thimble.

Cassie is on mat-leave right now, so I'll move this review to Kate.  Thanks for fixing this.
Attachment #814178 - Flags: review?(cassie) → review?(kate)
(Assignee)

Comment 7

5 years ago
(In reply to David Humphrey (:humph) from comment #6)
> Comment on attachment 814178 [details] [review]
> Minor fix for the font color for the preview and editor text in Thimble.
> 
> Cassie is on mat-leave right now, so I'll move this review to Kate.  Thanks
> for fixing this.

Alright thanks!
Comment on attachment 814178 [details] [review]
Minor fix for the font color for the preview and editor text in Thimble.

Just a style nit, use HEX colours instead of rgb.
Attachment #814178 - Flags: review?(kate) → review-
(Assignee)

Comment 9

5 years ago
(In reply to Kate Hudson (:k88hudson) from comment #8)
> Comment on attachment 814178 [details] [review]
> Minor fix for the font color for the preview and editor text in Thimble.
> 
> Just a style nit, use HEX colours instead of rgb.

Modification to use HEX colours instead is complete. :)
Attachment mime type: text/plain → text/x-github-pull-request
We're going to be reworking the UX for the integration with Teach, and this will shake out some of the issues in this bug.  WONTFIXING for now.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.