Closed Bug 911203 Opened 7 years ago Closed 7 years ago

TBPL support for emulator-jb builds

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: catlee, Assigned: RyanVM)

References

Details

Attachments

(1 file, 1 obsolete file)

Right now the emulator-jb builds are showing up the same as regular emulator builds
"b2g_b2g-inbound_emulator_dep"
"b2g_b2g-inbound_emulator-jb_dep"

they should probably be distinguished somehow.
Seemed inconsistent to me to specify JB on the new builds, but not ICS on the old ones, so I refactored the names a bit. Seems to work OK locally.
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #797895 - Flags: review?(emorley)
Actually, I like this a bit better.
Attachment #797895 - Attachment is obsolete: true
Attachment #797895 - Flags: review?(emorley)
Attachment #797898 - Flags: review?(emorley)
Attachment #797898 - Attachment is patch: true
Comment on attachment 797898 [details] [diff] [review]
add JB support and refactor the names a bit

Review of attachment 797898 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/Data.js
@@ +504,5 @@
>          /b2g.*_ics_armv7a_gecko_emulator_vm/i.test(name) ? "b2g-arm-vm" :
>          /b2g.*_ics_armv7a/i.test(name) ? "b2g-arm" :
> +        /b2g.*_emulator_vm/i.test(name) ? "b2g-emu-ics-vm" :
> +        /b2g.*_emulator-jb/i.test(name) ? "b2g-emu-jb" :
> +        /b2g.*_emulator/i.test(name) ? "b2g-emu-ics" :

Nit: Can you keep the two ics lines together? (With the "b2g-emu-ics" line obviously last to avoid false positives) :-)
Attachment #797898 - Flags: review?(emorley) → review+
Depends on: 911245
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.