911256 - mostly "startup" crash in sqlite3_finalize

Status: VERIFIED FIXED

(Toolkit :: Storage, defect)

Description

[Robert Kaiser]

This bug was filed from the Socorro interface and is 
report bp-a85a40a8-f7ad-4bb9-a94d-e9eeb2130829.
=============================================================

Top frames:
0 	nss3.dll 	sqlite3_finalize 	db/sqlite3/src/sqlite3.c
1 	xul.dll 	nsDocument::ClearBoxObjectFor(nsIContent *) 	content/base/src/nsDocument.cpp
2 	xul.dll 	mozilla::storage::Statement::internalFinalize(bool) 	storage/src/mozStorageStatement.cpp
3 	xul.dll 	nsNodeUtils::LastRelease(nsINode *) 	content/base/src/nsNodeUtils.cpp
4 	xul.dll 	mozilla::storage::Statement::~Statement() 	storage/src/mozStorageStatement.cpp
5 	xul.dll 	mozilla::storage::Statement::Release() 	storage/src/mozStorageStatement.cpp
6 	xul.dll 	mozilla::TimeStamp::operator-(mozilla::TimeStamp const &) 	obj-firefox/dist/include/mozilla/TimeStamp.h
7 	xul.dll 	ReleaseSliceNow(unsigned int,void *) 	xpcom/base/CycleCollectedJSRuntime.cpp
8 	xul.dll 	mozilla::TimeStamp::operator-(mozilla::TimeStamp const &) 	obj-firefox/dist/include/mozilla/TimeStamp.h
9 	xul.dll 	mozilla::IncrementalFinalizeRunnable::ReleaseNow(bool) 	xpcom/base/CycleCollectedJSRuntime.cpp
10 	nss3.dll 	MD_CURRENT_THREAD 	nsprpub/pr/src/md/windows/w95thred.c
11 	xul.dll 	mozilla::IncrementalFinalizeRunnable::Run() 	xpcom/base/CycleCollectedJSRuntime.cpp
12 	xul.dll 	nsThread::ProcessNextEvent(bool,bool *) 	xpcom/threads/nsThread.cpp


This is #1 over the last 3 days by build date in 26.0a1 desktop, it started spiking on 2013-08-28. 80% of those crashes happen in the first minute of execution (i.e. "on startup").

Comment 1

[Robert Kaiser]

Oh, more crashes, signature summary, etc. can be found at https://crash-stats.mozilla.com/report/list?signature=sqlite3_finalize

Comment 2

[V. Korn]

Its not only WinNT, i getting same crash
https://crash-stats.mozilla.com/report/index/959176e3-3b52-48af-b80d-847832130830
https://crash-stats.mozilla.com/report/index/b09f7896-0b3f-49aa-9760-deb122130830
https://crash-stats.mozilla.com/report/index/e55a3b34-3055-49db-869d-6cb5c2130830
on Xubuntu 13.04 64bit.

Comment 3

[Ekanan Ketunuti]

STR
- start nightly w/ clean profile
- install https://dl.dropboxusercontent.com/u/1045445/echofon.xpi && restart
- click at echofon button, add account, authorize app, close options window
- click at echofon button, close echofon window, close firefox
- bp-e863d808-d3e0-458e-8e81-8b6352130902

first bad nightly 2013-08-28

fx-team:
last-good 17e8229405fe
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/fx-team-win32/1377636378/

first bad c7d907403794
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/fx-team-win32/1377637698/

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Definitely related to bug 874814. Investigating.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Looks like we have a client of mozStorage that fails to release its resources as per API specifications. This used to kind-of-work, but bug 874814 makes that a near-certain crash. Investigating some more.

Comment 6

[David Teller [:Yoric] - still alive but not very active]

(In reply to Ekanan Ketunuti from comment #3)
> STR
> - start nightly w/ clean profile
> - install https://dl.dropboxusercontent.com/u/1045445/echofon.xpi && restart
> - click at echofon button, add account, authorize app, close options window
> - click at echofon button, close echofon window, close firefox
> - bp-e863d808-d3e0-458e-8e81-8b6352130902
> 
> first bad nightly 2013-08-28
> 
> fx-team:
> last-good 17e8229405fe
> https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/fx-team-
> win32/1377636378/
> 
> first bad c7d907403794
> https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/fx-team-
> win32/1377637698/

Note: This actually seems to be a bug in echofon.

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Normally, this has been fixed by bug 911109.
Please reopen if these crashes reappear.

Comment 8

[Robert Kaiser]

verified, the last crashes with this signatures are on the 2013-09-04 build.

Comment 9

[Ekanan Ketunuti]

Verified fixed using str in comment 3.
Crashes have completely stopped since buildid 20130905030206.