911346 - Add a test for whether WebGL works at all

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Attachment: test-webgl

We've been tripped up by this recently, when WebGL broke on b2g and we didn't notice. Really, we should just revive the tests that should be running there, but for now, let's just assure that it works at all.

The issue with this first patch is that it unconditionally tests for WebGL presence. Unfortunately, we're going to need a temporary way to mark this as known-fail. The WebGL conformance tests seem to have their own harness that handles this. Hopefully there's an easier way to do this here. Any ideas, bjacob?

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: patch: Add a test and useful util libs.

Here I rename `webgl-util.js` so we can use it elsewhere.
I also add a lib `driver-info.js` lib that we should try to at least keep synchronized in the tree, if not maybe eventually unify into one place.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 806212 [details] [diff] [review]
patch: Add a test and useful util libs.

Review of attachment 806212 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/test/webgl/non-conf-tests/Makefile.in
@@ +5,5 @@
>  
>  MOCHITEST_FILES = \
>    test_webgl_conformance.html \
>    test_webgl_request_mismatch.html \
> +  test_webgl_available.html \

Don't you need to add your two new .js files here too?

::: content/canvas/test/webgl/non-conf-tests/webgl-util.js
@@ +1,4 @@
> +WebGLUtil = (function() {
> +  // ---------------------------------------------------------------------------
> +  // Error handling
> +  

get a real text editor!!

Comment 3

[Kelsey Gilbert [:jgilbert]]

(In reply to Benoit Jacob [:bjacob] from comment #2)
> Comment on attachment 806212 [details] [diff] [review]
> patch: Add a test and useful util libs.
> 
> Review of attachment 806212 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/canvas/test/webgl/non-conf-tests/Makefile.in
> @@ +5,5 @@
> >  
> >  MOCHITEST_FILES = \
> >    test_webgl_conformance.html \
> >    test_webgl_request_mismatch.html \
> > +  test_webgl_available.html \
> 
> Don't you need to add your two new .js files here too?
Yes, I ran into this issue.
> 
> ::: content/canvas/test/webgl/non-conf-tests/webgl-util.js
> @@ +1,4 @@
> > +WebGLUtil = (function() {
> > +  // ---------------------------------------------------------------------------
> > +  // Error handling
> > +  
> 
> get a real text editor!!
It has this option, but it kills all trailing whitespace in a file that already has trailing whitespace. (as some of our files still do)

Comment 4

[Kelsey Gilbert [:jgilbert]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/cae77be484b9

Comment 5

[Kelsey Gilbert [:jgilbert]]

And for the whitespace I forgot:
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6255c31609be

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Both backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/28edd4a1bbaa for doing this https://tbpl.mozilla.org/php/getParsedLog.php?id=28125774&tree=Mozilla-Inbound

Comment 7

[Kelsey Gilbert [:jgilbert]]

https://tbpl.mozilla.org/?tree=Try&rev=9dec8a799444

Comment 8

[Kelsey Gilbert [:jgilbert]]

Attachment: patch for landing

Comment 9

[Kelsey Gilbert [:jgilbert]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f25d193dba4f

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f25d193dba4f