Closed Bug 911346 Opened 6 years ago Closed 6 years ago

Add a test for whether WebGL works at all

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(2 files, 1 obsolete file)

Attached patch test-webgl (obsolete) — Splinter Review
We've been tripped up by this recently, when WebGL broke on b2g and we didn't notice. Really, we should just revive the tests that should be running there, but for now, let's just assure that it works at all.

The issue with this first patch is that it unconditionally tests for WebGL presence. Unfortunately, we're going to need a temporary way to mark this as known-fail. The WebGL conformance tests seem to have their own harness that handles this. Hopefully there's an easier way to do this here. Any ideas, bjacob?
Attachment #798021 - Flags: review?(bjacob)
Attachment #798021 - Flags: review?(bjacob) → review+
Here I rename `webgl-util.js` so we can use it elsewhere.
I also add a lib `driver-info.js` lib that we should try to at least keep synchronized in the tree, if not maybe eventually unify into one place.
Assignee: nobody → jgilbert
Attachment #798021 - Attachment is obsolete: true
Attachment #806212 - Flags: review?(bjacob)
Comment on attachment 806212 [details] [diff] [review]
patch: Add a test and useful util libs.

Review of attachment 806212 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/test/webgl/non-conf-tests/Makefile.in
@@ +5,5 @@
>  
>  MOCHITEST_FILES = \
>    test_webgl_conformance.html \
>    test_webgl_request_mismatch.html \
> +  test_webgl_available.html \

Don't you need to add your two new .js files here too?

::: content/canvas/test/webgl/non-conf-tests/webgl-util.js
@@ +1,4 @@
> +WebGLUtil = (function() {
> +  // ---------------------------------------------------------------------------
> +  // Error handling
> +  

get a real text editor!!
Attachment #806212 - Flags: review?(bjacob) → review+
(In reply to Benoit Jacob [:bjacob] from comment #2)
> Comment on attachment 806212 [details] [diff] [review]
> patch: Add a test and useful util libs.
> 
> Review of attachment 806212 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/canvas/test/webgl/non-conf-tests/Makefile.in
> @@ +5,5 @@
> >  
> >  MOCHITEST_FILES = \
> >    test_webgl_conformance.html \
> >    test_webgl_request_mismatch.html \
> > +  test_webgl_available.html \
> 
> Don't you need to add your two new .js files here too?
Yes, I ran into this issue.
> 
> ::: content/canvas/test/webgl/non-conf-tests/webgl-util.js
> @@ +1,4 @@
> > +WebGLUtil = (function() {
> > +  // ---------------------------------------------------------------------------
> > +  // Error handling
> > +  
> 
> get a real text editor!!
It has this option, but it kills all trailing whitespace in a file that already has trailing whitespace. (as some of our files still do)
And for the whitespace I forgot:
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6255c31609be
https://hg.mozilla.org/mozilla-central/rev/f25d193dba4f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.