911347 - Intermittent test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpebndee\\ExecutableDir.tmp\\bin\\mimeTypes.rdf' etc..

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=27234346&tree=Mozilla-Inbound

Windows 7 32-bit mozilla-inbound opt test xpcshell on 2013-08-30 12:36:50 PDT for push 41a898465636
slave: t-w732-ix-119

12:51:25     INFO -  TEST-INFO | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | running test ...
12:51:29     INFO -  TEST-PASS | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | test passed (time: 3931.000ms)
12:51:29     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:30     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:31     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:32     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:33     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:34     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:35     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:36     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:37     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:38     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:39     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:40     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:41     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:42     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:43     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:44     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:45     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:46     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:47     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:48     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:49     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:50     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:51     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:52     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:53     INFO -  TEST-INFO | Failed to remove directory: c:\users\cltbld\appdata\local\temp\tmpebndee. Waiting.
12:51:54  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpebndee\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
12:51:54     INFO -  >>>>>>>

and so on...

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: Fix xpcshell static file cleanup on Windows

The problem is that our workaround was only for the plugin directory. It turns
out that this file still in use thing happens for other stuff as well. I suggest
we extend our current approach to include all file cleaning on Windows. It's
not pretty but I don't see a different way.

Talked to Mook_as in IRC and found out the reason why there is this delay between
closing the process and unlocking the file because of some "feature" of Windows
dealing with reopening files immediately.

Comment 2

[Legacy TBPL/Treeherder Robot]

Ms2ger%gmail.com
https://tbpl.mozilla.org/php/getParsedLog.php?id=27250760&tree=Mozilla-Inbound
Windows 7 32-bit mozilla-inbound debug test xpcshell on 2013-08-30 21:04:29
revision: 7d9e5022bf6c
slave: t-w732-ix-119

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpsc9s8h\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpsc9s8h\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0202_app_launch_apply_update_dirlocked.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpig5xax\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpig5xax\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0203_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmp0smt8a\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmp0smt8a\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_getTypeFromExtension_with_empty_Content_Type.js | test failed (with xpcshell return code: 3), see following log:
TypeError: _fakeIdleService is undefined
TypeError: print is not a function
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_handlerService.js | test failed (with xpcshell return code: 3), see following log:
TypeError: _fakeIdleService is undefined
TypeError: print is not a function
Return code: 1

Comment 3

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=27254249&tree=B2g-Inbound
WINNT 6.2 b2g-inbound pgo test xpcshell on 2013-08-31 00:12:09
revision: 4ba8dda1ee31
slave: t-w864-ix-031

WindowsError: [Error 5] Access is denied
WindowsError: [Error 5] Access is denied
WindowsError: [Error 5] Access is denied
WindowsError: [Error 5] Access is denied
WindowsError: [Error 5] Access is denied
WindowsError: [Error 5] Access is denied
WindowsError: [Error 5] Access is denied
WindowsError: [Error 5] Access is denied
WindowsError: [Error 5] Access is denied
WindowsError: [Error 5] Access is denied
WindowsError: [Error 5] Access is denied
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpeaghnp\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpeaghnp\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0202_app_launch_apply_update_dirlocked.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpfcnwnw\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpfcnwnw\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0203_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpnsxaqn\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpnsxaqn\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test_svc\unit\test_0201_app_launch_apply_update_svc.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpdmwxd1\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpdmwxd1\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test_svc\unit\test_0202_app_launch_apply_update_dirlocked_svc.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpe_tizz\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
Only displaying first 20 of 25 failures -
.

Comment 4

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=27264580&tree=Mozilla-Inbound
Windows XP 32-bit mozilla-inbound debug test xpcshell on 2013-08-31 08:52:42
revision: ea06b1ab196f
slave: t-xp32-ix-126

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmpywfjem\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmpywfjem\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0203_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmplk_1av\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmplk_1av\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_handlerService.js | test failed (with xpcshell return code: 3), see following log:
TypeError: _fakeIdleService is undefined
TypeError: print is not a function
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_punycodeURIs.js | test failed (with xpcshell return code: 3), see following log:
TypeError: _fakeIdleService is undefined
TypeError: print is not a function
Return code: 1

Comment 5

[Mihnea Dobrescu-Balaur (:mihneadb)]

Opened bug 911607 for the other error in the log file.

Comment 6

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=27286535&tree=Mozilla-Inbound
Windows 7 32-bit mozilla-inbound opt test xpcshell on 2013-09-01 22:37:49
revision: d6a0066e7081
slave: t-w732-ix-126

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpvtddkz\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpvtddkz\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0202_app_launch_apply_update_dirlocked.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpfejrve\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpfejrve\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0203_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpyu7gpt\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpyu7gpt\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_handlerService.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_getTypeFromExtension_with_empty_Content_Type.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_getTypeFromExtension_ext_to_type_mapping.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_punycodeURIs.js | test failed (with xpcshell return code: 3), see following log:
Return code: 1

Comment 7

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=27289183&tree=Mozilla-Inbound
Windows XP 32-bit mozilla-inbound debug test xpcshell on 2013-09-02 00:53:54
revision: 007e590f7e96
slave: t-xp32-ix-050

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmp0jlevl\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmp0jlevl\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0203_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmpi0qjuu\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmpi0qjuu\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_handlerService.js | test failed (with xpcshell return code: 3), see following log:
TypeError: _fakeIdleService is undefined
TypeError: print is not a function
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_punycodeURIs.js | test failed (with xpcshell return code: 3), see following log:
TypeError: _fakeIdleService is undefined
TypeError: print is not a function
Return code: 1

Comment 8

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=27292804&tree=Thunderbird-Trunk
TB Windows 7 32-bit comm-central opt test xpcshell on 2013-09-02 04:22:45
revision: dab224518b42
slave: t-w732-ix-124

TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpctfroj\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpctfroj\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0202_app_launch_apply_update_dirlocked.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpu2_jnd\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpu2_jnd\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0203_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpiw8odk\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpiw8odk\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\uriloader\exthandler\tests\unit\test_handlerService.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\uriloader\exthandler\tests\unit\test_getTypeFromExtension_ext_to_type_mapping.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\uriloader\exthandler\tests\unit\test_getTypeFromExtension_with_empty_Content_Type.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\uriloader\exthandler\tests\unit\test_punycodeURIs.js | test failed (with xpcshell return code: 3), see following log:

Comment 9

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=27318008&tree=Mozilla-Inbound
Windows 7 32-bit mozilla-inbound opt test xpcshell on 2013-09-03 02:32:01
revision: 3171b6ad0055
slave: t-w732-ix-025

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpkrdipq\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpkrdipq\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0202_app_launch_apply_update_dirlocked.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpnymt9v\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpnymt9v\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0203_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpstei11\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpstei11\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_handlerService.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_punycodeURIs.js | test failed (with xpcshell return code: 3), see following log:
Return code: 1

Comment 10

[(not currently active) Ted Mielczarek]

Comment on attachment 798026 [details] [diff] [review]
Fix xpcshell static file cleanup on Windows

Review of attachment 798026 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/xpcshell/runxpcshelltests.py
@@ +376,5 @@
>                  # removed fine
>                  return
>  
> +        # we try again later at the end of the run for windows
> +        if 'WindowsError' in traceback.format_exc():

This is a really weird way to test for Windows. I'd prefer if you just used mozinfo.isWin. Alternately, any reason not to just drop the conditional here and always queue directories for later cleanup? Shouldn't be harmful on any platform.

Comment 11

[Mihnea Dobrescu-Balaur (:mihneadb)]

You are absolutely correct, I'll fix it.

Comment 12

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=27331353&tree=Mozilla-Central
WINNT 6.2 mozilla-central pgo test xpcshell on 2013-09-03 09:07:55
revision: 7ff96bd19c1c
slave: t-w864-ix-123

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpgehyjv\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpgehyjv\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0202_app_launch_apply_update_dirlocked.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpvk_r5r\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpvk_r5r\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0203_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpnimwdn\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpnimwdn\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test_svc\unit\test_0201_app_launch_apply_update_svc.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmplvsook\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmplvsook\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test_svc\unit\test_0202_app_launch_apply_update_dirlocked_svc.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpoz1xc8\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpoz1xc8\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test_svc\unit\test_0203_app_launch_apply_update_svc.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpxj6n15\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpxj6n15\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_handlerService.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_punycodeURIs.js | test failed (with xpcshell return code: 3), see following log:
Return code: 1

Comment 13

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=27331714&tree=Mozilla-Inbound
WINNT 6.2 mozilla-inbound opt test xpcshell on 2013-09-03 09:10:21
revision: a484e79df631
slave: t-w864-ix-117

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpuvr3rp\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpuvr3rp\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0202_app_launch_apply_update_dirlocked.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpptwuld\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpptwuld\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0203_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpicw8oh\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpicw8oh\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test_svc\unit\test_0201_app_launch_apply_update_svc.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpwgkurc\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpwgkurc\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test_svc\unit\test_0202_app_launch_apply_update_dirlocked_svc.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpdgx0mc\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpdgx0mc\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test_svc\unit\test_0203_app_launch_apply_update_svc.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpzeiljn\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\tmpzeiljn\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_handlerService.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_punycodeURIs.js | test failed (with xpcshell return code: 3), see following log:
Return code: 1

Comment 14

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: Fix xpcshell static file cleanup on Windows

Please note that this means we won't error if we can't clean up any temp directory
that we set up for a test. Then again, I've never seen this happen other than
on Windows because of the file locking thing.

Also, Linux and OS X let you remove a file that is in use by a process so the
check was only affecting Windows anyway.

Comment 15

[(not currently active) Ted Mielczarek]

Comment on attachment 798940 [details] [diff] [review]
Fix xpcshell static file cleanup on Windows

Review of attachment 798940 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine. I don't think it's worth the orange pain for this case that we can't do much about. Our test slaves have their temp dirs cleaned on reboot nowadays, so this shouldn't lead to problems down the road.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1153ba67c760

Comment 17

[Legacy TBPL/Treeherder Robot]

dkeeler
https://tbpl.mozilla.org/php/getParsedLog.php?id=27338908&tree=Try
Windows XP 32-bit try debug test xpcshell on 2013-09-03 13:41:58
revision: 4fb8047aa22a
slave: t-xp32-ix-038

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmprbvgrl\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmprbvgrl\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0203_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmpmf4r20\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmpmf4r20\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_getTypeFromExtension_with_empty_Content_Type.js | test failed (with xpcshell return code: 3), see following log:
TypeError: _fakeIdleService is undefined
TypeError: print is not a function
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_handlerService.js | test failed (with xpcshell return code: 3), see following log:
TypeError: _fakeIdleService is undefined
TypeError: print is not a function
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_punycodeURIs.js | test failed (with xpcshell return code: 3), see following log:
TypeError: _fakeIdleService is undefined
TypeError: print is not a function
Return code: 1

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1153ba67c760

Comment 19

[Legacy TBPL/Treeherder Robot]

Standard8
https://tbpl.mozilla.org/php/getParsedLog.php?id=27331929&tree=Thunderbird-Trunk
TB Windows XP 32-bit comm-central opt test xpcshell on 2013-09-03 09:40:45
revision: e7a7f385ce1c
slave: t-xp32-ix-085

TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmpzkiwu4\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmpzkiwu4\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0203_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmpieigvi\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmpieigvi\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\uriloader\exthandler\tests\unit\test_handlerService.js | test failed (with xpcshell return code: 3), see following log:

Comment 20

[Legacy TBPL/Treeherder Robot]

botond
https://tbpl.mozilla.org/php/getParsedLog.php?id=27786746&tree=Try
Windows 7 32-bit try opt test xpcshell on 2013-09-12 12:58:05
revision: 1c3069f3eec2
slave: t-w732-ix-114

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0201_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmp6nnw1f\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmp6nnw1f\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0202_app_launch_apply_update_dirlocked.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpik6fqr\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpik6fqr\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\mozapps\update\test\unit\test_0203_app_launch_apply_update.js | Failed to clean up directory: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpt2_idb\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
WindowsError: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmpt2_idb\\ExecutableDir.tmp\\bin\\mimeTypes.rdf'
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_getTypeFromExtension_with_empty_Content_Type.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_handlerService.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\uriloader\exthandler\tests\unit\test_punycodeURIs.js | test failed (with xpcshell return code: 3), see following log:
Return code: 1