Closed Bug 911359 Opened 11 years ago Closed 11 years ago

Remove __STDC_LIMIT_MACROS from gonk-misc/Unicode.h

Categories

(Core Graveyard :: Widget: Gonk, defect)

Product:
Core Graveyard
Component:
Widget: Gonk
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.2 FC (16sep)

People

(Reporter: zbraniecki, Assigned: hub)

References

Details

(Whiteboard: [c= p= s=2013.09.20 u=]) 

Since it's now defined in mozilla-central/mozilla.config.h it shows nasty warnings:

In file included from <command-line>:0:
/Volumes/fxos/B2G/gonk-misc/Unicode.h:20:1: warning: "__STDC_LIMIT_MACROS" redefined
In file included from <command-line>:0:
./../../mozilla-config.h:182:1: warning: this is the location of the previous definition
In file included from <command-line>:0:
/Volumes/fxos/B2G/gonk-misc/Unicode.h:20:1: warning: "__STDC_LIMIT_MACROS" redefined
In file included from <command-line>:0:
./../../mozilla-config.h:182:1: warning: this is the location of the previous definition
UserProximityEventBinding.o
it's related to landing of bug 812218 which make's mozilla-config.h's include earlier than user-defined ones.
Thanks - this looks good. Just one thing - can you also remove the #undef of __STDC_LIMIT_MACROS at the end of the file?
Assignee: nobody → gandalf
Taking over. See bug 914471 comment 5
Assignee: gandalf → hub
Blocks: 914471
No longer blocks: 914471
r?
Flags: needinfo?(mwu)
Merged, thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(mwu)
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Target Milestone: mozilla26 → 1.2 FC (16sep)
Whiteboard: [c= p= s=2013.09.20 u=]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.