911395 - Gaia unit tests badly broken in TBPL: "assert is undefined"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jonathan Griffin (:jgriffin)]

The gaia-unit tests have been not running in TBPL for a few days due to bug 908698.  That's been fixed, and now we see that over 500 tests are failing with the error:

"assert is undefined"

full log: https://tbpl.mozilla.org/php/getParsedLog.php?id=27242386#error0

Comment 1

[Julien Wajsberg [:julienw]]

Mmm this is all in the unit tests for the System app.

Etienne, you may have an idea ?

Comment 2

[Etienne Segonzac (:etienne)]

How is tbpl running the tests?
Are we running the unit test and the marionette tests at the same time?

We have some JS-error related to a marionette test (test/marionette/notification_test.js) in the middle of running unit tests...

Since those integration tests have been added recently it might be related.

Can we make sure we don't try to run the integration/marionette tests while doing the unit test harness?

Comment 3

[Jonathan Griffin (:jgriffin)]

Ah, it's unfortunately we can't distinguish unit and integration tests except by directory name.  I'll update the testrunner.

Comment 4

[Jonathan Griffin (:jgriffin)]

PR for testrunner update: https://github.com/mozilla-b2g/gaia/pull/11929

Comment 5

[Etienne Segonzac (:etienne)]

Somebody feels confident reviewing this?

Comment 6

[Julien Wajsberg [:julienw]]

In the past, :aki and :mdas reviewed this file.

I don't know enough python to review this for sure. Maybe :rik can give it a stab though ?

Comment 7

[Anthony Ricaud (:rik)]

It looks like the correct fix. I just have a small suggestion in the PR.

Comment 8

[Aki Sasaki [:aki] (he/him) (UTC-6)]

Looks like this is taken care of?

Comment 9

[Jonathan Griffin (:jgriffin)]

https://github.com/mozilla-b2g/gaia/commit/fbe6cab492b912968b8318daf8102a20af27b2a7