Closed Bug 911395 Opened 8 years ago Closed 8 years ago

Gaia unit tests badly broken in TBPL: "assert is undefined"

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

The gaia-unit tests have been not running in TBPL for a few days due to bug 908698.  That's been fixed, and now we see that over 500 tests are failing with the error:

"assert is undefined"

full log: https://tbpl.mozilla.org/php/getParsedLog.php?id=27242386#error0
Mmm this is all in the unit tests for the System app.

Etienne, you may have an idea ?
Component: Gaia → Gaia::System
Flags: needinfo?(etienne)
Assignee: nobody → etienne
Flags: needinfo?(etienne)
How is tbpl running the tests?
Are we running the unit test and the marionette tests at the same time?

We have some JS-error related to a marionette test (test/marionette/notification_test.js) in the middle of running unit tests...

Since those integration tests have been added recently it might be related.

Can we make sure we don't try to run the integration/marionette tests while doing the unit test harness?
Flags: needinfo?(jgriffin)
Ah, it's unfortunately we can't distinguish unit and integration tests except by directory name.  I'll update the testrunner.
Flags: needinfo?(jgriffin)
Somebody feels confident reviewing this?
Flags: needinfo?(jlal)
Flags: needinfo?(felash)
In the past, :aki and :mdas reviewed this file.

I don't know enough python to review this for sure. Maybe :rik can give it a stab though ?
Flags: needinfo?(mdas)
Flags: needinfo?(felash)
Flags: needinfo?(anthony)
Flags: needinfo?(aki)
It looks like the correct fix. I just have a small suggestion in the PR.
Flags: needinfo?(anthony)
Looks like this is taken care of?
Flags: needinfo?(aki)
Assignee: etienne → jgriffin
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.