Closed Bug 911414 Opened 12 years ago Closed 12 years ago

Collection API should allow filtering on empty values

Categories

(Marketplace Graveyard :: API, defect, P1)

Product:
Marketplace Graveyard
Component:
API
Platform:
x86_64
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-09-10

People

(Reporter: mat, Assigned: mat)

Details

(Whiteboard: [qa-])

The Collection API currently doesn't let you filter on empty values, such as '?category='. It's needed to be able to find Collections that have category=None. This is going to require either patching django-filter or just completely remove django-filter, because it really doesn't like None/'' values. Originally reported in https://bugzilla.mozilla.org/show_bug.cgi?id=911382 but I splitted the bug in two.
Assignee: nobody → mpillard
Priority: -- → P1
Target Milestone: --- → 2013-09-10
https://github.com/mozilla/zamboni/pull/1082 Shall fix this bug and bug 911382 as well.
Status: NEW → ASSIGNED
Fixed in https://github.com/mozilla/zamboni/commit/e2e71c7579fc1ef0f32de896c0c2d6b7f453fcdf We now allow null values when filtering. To pass them, you need to omit the value in the query string, the docs are updated to mention this.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Can you please add some STRs to this bug or mark it as [qa-] ?
I'll let basta test this
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.