911425 - [-Wsign-compare] comparison of integers of different signs: 'off_t' (aka 'long long') and 'unsigned long long'

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-FileUtils-Wsign-compare.patch

Fix clang warning on OS X introduced by bug 845907:

xpcom/glue/FileUtils.cpp:459:13 [-Wsign-compare] comparison of integers of different signs: 'off_t' (aka 'long long') and 'unsigned long long'

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 798136 [details] [diff] [review]
fix-FileUtils-Wsign-compare.patch

Review of attachment 798136 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/glue/FileUtils.cpp
@@ +449,5 @@
>    // loader is going to map the file in memory. We use that
>    // information to find the biggest offset from the library that
>    // will be mapped in memory.
>    char *cmd = &base[sizeof(struct cpu_mach_header)];
> +  size_t end = 0;

might as well make it a uint32_t, since that's what it's defined to in mach-o headers. Don't worry about overflows, all that'd achieve is doing less readahead.

Comment 2

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a23243301c9

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3a23243301c9