Closed Bug 911474 Opened 11 years ago Closed 11 years ago

Intermittent test_DownloadIntegration.js | test failed (with xpcshell return code: 0) | 0 == 2 | Unexpected exception 2147500036

Categories

(Toolkit :: Downloads API, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27
Tracking Status
firefox25 --- unaffected
firefox26 --- fixed
firefox27 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: RyanVM, Assigned: Paolo)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=27246879&tree=Mozilla-Inbound

Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound opt test xpcshell on 2013-08-30 19:25:43 PDT for push c59d6e7fdee5
slave: talos-mtnlion-r5-016

19:37:19     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | running test ...
19:37:23  WARNING -  TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | test failed (with xpcshell return code: 0), see following log:
19:37:23     INFO -  >>>>>>>
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test MAIN run_test pending (1)
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 0 pending (2)
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test MAIN run_test finished (2)
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | running event loop
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | Starting test_common_initialize
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test test_common_initialize pending (2)
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 1 pending (3)
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test test_common_initialize finished (3)
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 0 finished (2)
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | Starting test_getSystemDownloadsDirectory
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test test_getSystemDownloadsDirectory pending (2)
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getSystemDownloadsDirectory : 91] true == true
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getSystemDownloadsDirectory : 92] "/var/folders/lr/nwz2bgs53v1_nr5s75sk7lqh00000w/T/tmpfcl9Bb" == "/var/folders/lr/nwz2bgs53v1_nr5s75sk7lqh00000w/T/tmpfcl9Bb"
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 1 finished (2)
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getSystemDownloadsDirectory : 93] true == true
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getSystemDownloadsDirectory : 96] true == true
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getSystemDownloadsDirectory : 115] false == false
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 2 pending (2)
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test test_getSystemDownloadsDirectory finished (2)
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | Starting test_getUserDownloadsDirectory
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test test_getUserDownloadsDirectory pending (2)
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getUserDownloadsDirectory : 136] true == true
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getUserDownloadsDirectory : 137] "/Users/cltbld/Downloads" == "/Users/cltbld/Downloads"
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getUserDownloadsDirectory : 142] true == true
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getUserDownloadsDirectory : 143] "/Users/cltbld/Desktop" == "/Users/cltbld/Desktop"
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getUserDownloadsDirectory : 149] true == true
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getUserDownloadsDirectory : 150] "/Users/cltbld/Downloads" == "/Users/cltbld/Downloads"
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 2 finished (2)
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getUserDownloadsDirectory : 158] true == true
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getUserDownloadsDirectory : 159] "/var/folders/lr/nwz2bgs53v1_nr5s75sk7lqh00000w/T/tmpfcl9Bb/1377916640205" == "/var/folders/lr/nwz2bgs53v1_nr5s75sk7lqh00000w/T/tmpfcl9Bb/1377916640205"
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getUserDownloadsDirectory : 160] true == true
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getUserDownloadsDirectory : 170] "/Users/cltbld/Downloads" == "/Users/cltbld/Downloads"
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getUserDownloadsDirectory : 176] "/Users/cltbld/Downloads" == "/Users/cltbld/Downloads"
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 3 pending (2)
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test test_getUserDownloadsDirectory finished (2)
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | Starting test_getTemporaryDownloadsDirectory
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test test_getTemporaryDownloadsDirectory pending (2)
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getTemporaryDownloadsDirectory : 188] true == true
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [test_getTemporaryDownloadsDirectory : 192] "/Users/cltbld/Downloads" == "/Users/cltbld/Downloads"
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 4 pending (3)
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test test_getTemporaryDownloadsDirectory finished (3)
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 3 finished (2)
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | Starting test_notifications
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test test_notifications pending (2)
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | "Interruptible responses will be blocked midway."
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | [getTempFile : 133] false == false
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | [getTempFile : 133] false == false
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | [getTempFile : 133] false == false
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 4 finished (2)
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [notifyPromptObservers : 44] 2 == 2
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | [notifyPromptObservers : 49] 2 == 2
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | "Interruptible responses are now allowed to continue."
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | "Interruptible request started."
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | "Interruptible request finished."
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | "Interruptible request started."
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | "Interruptible request finished."
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | [getTempFile : 133] false == false
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | [getTempFile : 133] false == false
19:37:23     INFO -  TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | [getTempFile : 133] false == false
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | "Interruptible request started."
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | "Interruptible request finished."
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | "Interruptible request started."
19:37:23     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/head.js | "Interruptible request finished."
19:37:23  WARNING -  TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js | 0 == 2 - See following stack:
19:37:23     INFO -  JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js :: notifyPromptObservers :: line 44
19:37:23     INFO -  JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js :: test_notifications :: line 228
19:37:23     INFO -  JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 198
19:37:23     INFO -  JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 118
19:37:23     INFO -  JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 43
19:37:23     INFO -  JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 185
19:37:23     INFO -  JS frame :: resource://gre/modules/DownloadCore.jsm :: <TOP_LEVEL> :: line 511
19:37:23     INFO -  JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 133
19:37:23     INFO -  JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 133
19:37:23     INFO -  JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 52
19:37:23     INFO -  JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 185
19:37:23     INFO -  JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 208
19:37:23     INFO -  JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 229
19:37:23     INFO -  JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 133
19:37:23     INFO -  JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 52
19:37:23     INFO -  JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 185
19:37:23     INFO -  JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: reject :: line 208
19:37:23     INFO -  JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 229
19:37:23     INFO -  JS frame :: resource://gre/modules/Promise.jsm :: <TOP_LEVEL> :: line 568
19:37:23     INFO -  JS frame :: resource://gre/modules/Promise.jsm :: <TOP_LEVEL> :: line 350
19:37:23     INFO -  native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | exiting test
19:37:23  WARNING -  TEST-UNEXPECTED-FAIL | resource://gre/modules/commonjs/sdk/core/promise.js | Unexpected exception 2147500036
19:37:23     INFO -  TEST-INFO | (xpcshell/head.js) | exiting test
19:37:23     INFO -  !!! error running onStopped callback: TypeError: callback is not a function
19:37:23     INFO -  <<<<<<<
The issue is here that by the time notifyPromptObservers is called, the downloads may have already finished, so notifyPromptObservers has no downloads to prompt about.
Attached patch The patchSplinter Review
Ah, missed that mustInterruptResponses() should be called within the loop.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Attachment #808492 - Flags: review?(enndeakin)
Attachment #808492 - Flags: review?(enndeakin) → review+
https://hg.mozilla.org/mozilla-central/rev/c6a4c2d8bfb5
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: