911530 - [MP] Defect - Junior style buttons not appearing after swiping autocomplete window away

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P2)

Description

[Kamil Jozwiak [:kjozwiak]]

When the user swipes away the "search for" window, the junior style buttons will not reappear on the screen. Once the user taps anywhere on the website, the icons will reappear.

Steps to reproduce the issue:

1) Open Firefox Metro
2) Go to wikipedia.org
3) Once the website has been loaded, tap on the URL bar that's located in the Navigation App Bar and start typing anything (the "search for" window should appear)
4) Now instead of tapping on the website to dismiss the "search for" window, swipe down on the website and you'll notice the "search for" window dismissing but the junior flyout buttons will not reappear
5) Tap anywhere on the website and the buttons will reappear

Current Behavior:

- When swiping way the "search for" window, the junior style buttons will not appear

Expected Behavior:

- Junior style buttons should reappear after the user swipes the "search for" window

Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-31-03-02-24-mozilla-central/

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

The attribute for autocomplete was not being removed which caused the css style for the junior style buttons to not be reflected.  This simply calls closePopup when the navbar is dismissed to ensure that the attribute is always removed.

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

Ugh, with bug 898106 this gets real nasty as the dimming panel stays after dismissing. The dim panel will not go away and will not let you interact with content!

Comment 3

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/fx-team/rev/5785838279d6

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5785838279d6

Comment 5

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #15 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-30-03-02-05-mozilla-central/

- Went through the original issue described in comment #0 without any issues
- Ensured that when the "search for" window and OSK are visible, user(s) cannot scroll through the current website
- Ensured that both of the junior style buttons are visible and functional when pressing "ESC" when both the "search for" and OSK windows are visible
- Ensured that both of the junior style buttons are visible and functional when the user dismisses both of the "search for" window and OSK by tapping on the current website
- Ensured that both of the junior style buttons are visible and functional when the user dismisses both of the "search for" window and OSK by sliding in the Windows Charm App Bar
- Ensured that both of the junior style buttons are visible and functional when the user dismisses both of the "search for" window and OSK by pressing "Windows + Z"
- Went through all of the above test cases using full & filled views