If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

build script settings.js would return error when setting GAIA_DEV_PIXELS_PER_PX=1.5

RESOLVED FIXED

Status

Firefox OS
GonkIntegration
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rudyl, Assigned: yurenju)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

STR
====
1. in Gaia master branch
2. build Gaia with GAIA_DEV_PIXELS_PER_PX=1.5
    > GAIA_DEV_PIXELS_PER_PX=1.5 make

--
[Error log]
run-js-command  settings
XMLHttpRequest.send error: [Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/rudy/Dev/orig_gaia/build/settings.js :: readFileAsDataURL :: line 17"  data: no]
make: *** [profile/settings.json] Error 3
Assignee: nobody → yurenju.mozilla
Created attachment 798409 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/11882

We should fallback to GAIA_DIR/build/wallpaper.jpg if wallpaper@<DEVICE_PIXEL>.jpg not avaiable.
Attachment #798409 - Flags: review?(timdream)
Attachment #798409 - Flags: review?(timdream) → review+
verified on Windows & merged.

https://github.com/mozilla-b2g/gaia/commit/33fb7dfe0b5a47c8146e4ea6837cc030369c90d5
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.