911669 - [B2G][Helix][Camera][ouyangming] The flash's state is different between the android device when do the same operation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[lecky]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; aff-kingsoft-ciba; .NET4.0C; .NET4.0E)

Steps to reproduce:

1. Open the camera App, and let the camera mode is back, and turn on the flash.
2. Change the camera mode from back to front.
3. Change the camera mode from front to back.


Actual results:

On FFOS device:
 1. In step 2, the flash is off.
 2. In step 3, the flash is off.
On android device:
 1. In step 2, the flash is off.
 2. In step 3, the flash is on.


Expected results:

We want the flash is on in step 3 on FFOS.
If we do, the flash's state is the same with the android device in step 3.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

This bug is confirmed.

Camera app turns off flash when switching camera from back to front and vice visa.

I take this and start to make a patch for this bug.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: make flashstate support multiple camera instances and delay the initialization of flashstate object

The original state is shared by all camera instance. Once app changes camera, it turns flash state to off no matter it supports or not. This patch makes the following changes:
1. make flash state to support multiple camera
2. delay the initialization when that camera is used.
3. automatically turns off flash/torch when the active camera is not supported.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

This bug is also happened to master.

Comment 4

[David Flanagan [:djf]]

Comment on attachment 799302 [details]
make flashstate support multiple camera instances and delay the initialization of flashstate object

Our flash handling code is a mess. But this patch looks fine. I have not tested it myself, but if you have, go ahead and land it.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Yes, it is a mass. I had tried to move it out. But it is too complex. I think it may be moved with the controlling code of Camera. Maybe, the time of switching to WebRTC is a good time to move them.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/da85897147713e21d32cefd4c4837007c79ed516

Comment 7

[Jason Smith [:jsmith]]

Note - This caused bug 913418.

Comment 8

[lecky]

Hi Wayne :
 Please help us to push to merge this case into V1.1 HD. It blocked the Helix Device .If you can not resolve it , please get the authorization from carrier.

Thanks.

Comment 9

[Wayne Chang [:wchang]]

HD+'ing this as device specific.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This landed on master prior to v1.2 branching, no?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Tim, can you uplift this to v1.1hd please? :)

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/bc2fae70e6511096a067576a29f4b9750929dca0