911670 - [Settings] Change the wording of 'phonelock' to for general meaning

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Currently the lockscreen related setting is called 'phonelock' in 'privacy & security' section.

But in tablet or non-telephony devices there's no 'phone' in mind.

We need more general word to apply for these scenario.

Comment 1

[[e-mail]]

cc UX to provide better wording

Comment 2

[Stephany Wilkes]

Flagging Matej, who handles copy and can suggest a new string.

Comment 3

[Matej Novak [:matej]]

Would "screen lock" work?

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Fred, Matej

I think "Screen lock" is better than the previous one. 

I just changed the property list with correct wordings in zh_TW and en_US.

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: Pointer to Github pull request 12017.html

Hi Arthur, 

Can you help review this wording change ? Thanks.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 801353 [details]
Pointer to Github pull request 12017.html

Thank you for the effort! r=me.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: https://github.com/mozilla-b2g/gaia/commit/aa003f26aec56917323f5db82d54144f91ee1301

Comment 8

[Axel Hecht [:Pike]]

This change landed without changing the string ID, and won't be picked up as is.

Can you please file a follow-up to fix this?

Also, is there a reason why this is koi+ and not uplifted?