9117 - [patch] xpinstall build fix for HP-UX

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[tor]

The HP compiler doesn't like creating a reference to a temporary:

     "../../../xpinstall/src/nsInstallUninstall.cpp", line 185.52: 1540-224: (S)
Conversion from "nsFileSpec" to a reference to a non-const type "nsFileSpec&"
requires a temporary.
     "../../../xpinstall/src/nsInstallUninstall.cpp", line 192.48: 1540-224: (S)
Conversion from "nsFileSpec" to a reference to a non-const type "nsFileSpec&"
requires a temporary.

This small patch should take care of these problems

diff -u -r1.3 nsInstallUninstall.cpp
--- nsInstallUninstall.cpp      1999/05/27 21:02:52     1.3
+++ nsInstallUninstall.cpp      1999/07/01 04:46:10
@@ -182,14 +182,16 @@
             else
             {
                 err = VR_Remove(component_path);
-                DeleteFileNowOrSchedule(nsFileSpec(filepath));
+                nsFileSpec fpath(filepath);
+                DeleteFileNowOrSchedule(fpath);
             }
         }
         else
         {
             /* delete node and file */
             err = VR_Remove(component_path);
-            DeleteFileNowOrSchedule(nsFileSpec(filepath));
+            nsFileSpec fpath(filepath);
+            DeleteFileNowOrSchedule(fpath);
         }
     }
     return err;

Comment 1

[Daniel Veditz [:dveditz]]

Thanks very much. I went ahead and made the parameters const instead (got a
patch for AIX having the same problem) but should solve your problem
nonetheless.

Comment 2

[Jimmy Lee]

Build 7/13/99

Marking verified.  If new or similar problem is found, a new bug report will be
opened.

Comment 3

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine