911714 - Backgrounded apps remain visible to screen reader

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eitan Isaacson [:eeejay]]

Currently, background apps are simply obscured by z-order. Our screen reader still picks it up. We need to explicitly hide background apps.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Hide backgrounded windows, and show foreground window.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Hide backgrounded windows, and show foreground window.

The aria-hidden attribute needs to be applied to the iframe because of the way the accessible tree is constructed.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 801758 [details] [diff] [review]
Hide backgrounded windows, and show foreground window.

Review of attachment 801758 [details] [diff] [review]:
-----------------------------------------------------------------

Could we put aria-hidden on the frame (div.appWindow) instead of iframe element?
There would be other elements in the appWindow container other than iframe.
I don't know the detail of screen reader though.

Please send a pull request as well.

Comment 4

[Eitan Isaacson [:eeejay]]

(In reply to Alive Kuo [:alive] from comment #3)
> Comment on attachment 801758 [details] [diff] [review]
> Hide backgrounded windows, and show foreground window.
> 
> Review of attachment 801758 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Could we put aria-hidden on the frame (div.appWindow) instead of iframe
> element?
> There would be other elements in the appWindow container other than iframe.

What other elements? In any case, I will update this with a version that gives the frame an explicit region role so that it is not pruned in the accessible tree and is available to the screen reader.

> I don't know the detail of screen reader though.
> 
> Please send a pull request as well.

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Hide backgrounded windows, and show foreground window.

https://github.com/mozilla-b2g/gaia/pull/12046

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 801831 [details] [diff] [review]
Hide backgrounded windows, and show foreground window.

I trust the un-hiding of the home screen is done in one of the other code paths, right? Because I only see here where the home screen is explicitly hidden, but not un-hidden.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Marco Zehe (:MarcoZ) from comment #6)
> Comment on attachment 801831 [details] [diff] [review]
> Hide backgrounded windows, and show foreground window.
> 
> I trust the un-hiding of the home screen is done in one of the other code
> paths, right? Because I only see here where the home screen is explicitly
> hidden, but not un-hidden.

https://github.com/eeejay/gaia/blob/54e842a1a841fde841bd450e9af80e478ec84985/apps/system/js/window_manager.js#L474

open homescreen path would go through here.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Eitan Isaacson [:eeejay] from comment #4)
> (In reply to Alive Kuo [:alive] from comment #3)
> 
> What other elements? In any case, I will update this with a version that
> gives the frame an explicit region role so that it is not pruned in the
> accessible tree and is available to the screen reader.

I'm going to put alert prompt confirm - modal dialog in the frame as well.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 801831 [details] [diff] [review]
Hide backgrounded windows, and show foreground window.

Review of attachment 801831 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Do you need me to merge for you?

Comment 10

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/433dc0a6baed276ff07d15252f5d8d5c14fb4cc3

Comment 11

[Eitan Isaacson [:eeejay]]

Thanks!