911741 - icu doesn't use optimize flag

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

add $MOZ_OPTIMIZE_FLAGS to CFLAGS

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 798494 [details] [diff] [review]
fix

current build log in the latest m-c is the following.
https://tbpl.mozilla.org/php/getParsedLog.php?id=27285860&tree=Mozilla-Central&full=1
cl -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DUCONFIG_NO_BREAK_ITERATION   -DHAVE_DLOPEN=0 -DU_HAVE_MMAP=0 -DU_HAVE_INTTYPES_H=0 -DU_HAVE_DIRENT_H=0 -DU_HAVE_POPEN=0  -DU_STATIC_IMPLEMENTATION -DU_RELEASE=1 -D_CRT_SECURE_NO_DEPRECATE -I/e/builds/moz2_slave/m-cen-w32-pgo-0000000000000000/build/js/src/../../intl/icu/source/common   "-DDEFAULT_ICU_PLUGINS=\"/usr/local/lib/icu\" " -DU_ATTRIBUTE_DEPRECATED= -DWIN32 -DCYGWINMSVC -DU_COMMON_IMPLEMENTATION  -Gy -MD -W4  -GF -nologo  -c   -Foudatamem.obj /e/builds/moz2_slave/m-cen-w32-pgo-0000000000000000/build/js/src/../../intl/icu/source/common/udatamem.c
udatamem.c

So no -O? build opt even if PGO, we should add $MOZ_OPTIMIZE_FLAG to $CFLAGS when configure of ICU.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 798494 [details] [diff] [review]
fix

Review of attachment 798494 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense to me. Although, I do wonder if there's a better way to do this. This solution seems to address the problem of "pass optimization flags" instead of "pass all compiler flags that are suitable for subprojects." Meh.

Comment 4

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1791f7250a6c

Comment 5

[Makoto Kato [:m_kato]]

To use all our compiler flags, we should use configure instead of runConfigureICU.
But, before this, I will add cross compiler support.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1791f7250a6c