Closed Bug 911741 Opened 6 years ago Closed 6 years ago

icu doesn't use optimize flag

Categories

(Firefox Build System :: General, defect)

x86
Windows 8
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

add $MOZ_OPTIMIZE_FLAGS to CFLAGS
Summary: icu isn't use optimize flag → icu doesn't use optimize flag
Attached patch fixSplinter Review
Comment on attachment 798494 [details] [diff] [review]
fix

current build log in the latest m-c is the following.
https://tbpl.mozilla.org/php/getParsedLog.php?id=27285860&tree=Mozilla-Central&full=1
cl -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DUCONFIG_NO_BREAK_ITERATION   -DHAVE_DLOPEN=0 -DU_HAVE_MMAP=0 -DU_HAVE_INTTYPES_H=0 -DU_HAVE_DIRENT_H=0 -DU_HAVE_POPEN=0  -DU_STATIC_IMPLEMENTATION -DU_RELEASE=1 -D_CRT_SECURE_NO_DEPRECATE -I/e/builds/moz2_slave/m-cen-w32-pgo-0000000000000000/build/js/src/../../intl/icu/source/common   "-DDEFAULT_ICU_PLUGINS=\"/usr/local/lib/icu\" " -DU_ATTRIBUTE_DEPRECATED= -DWIN32 -DCYGWINMSVC -DU_COMMON_IMPLEMENTATION  -Gy -MD -W4  -GF -nologo  -c   -Foudatamem.obj /e/builds/moz2_slave/m-cen-w32-pgo-0000000000000000/build/js/src/../../intl/icu/source/common/udatamem.c
udatamem.c

So no -O? build opt even if PGO, we should add $MOZ_OPTIMIZE_FLAG to $CFLAGS when configure of ICU.
Attachment #798494 - Flags: review?(gps)
Comment on attachment 798494 [details] [diff] [review]
fix

Review of attachment 798494 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense to me. Although, I do wonder if there's a better way to do this. This solution seems to address the problem of "pass optimization flags" instead of "pass all compiler flags that are suitable for subprojects." Meh.
Attachment #798494 - Flags: review?(gps) → review+
To use all our compiler flags, we should use configure instead of runConfigureICU.
But, before this, I will add cross compiler support.
https://hg.mozilla.org/mozilla-central/rev/1791f7250a6c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.