Closed Bug 911767 Opened 11 years ago Closed 11 years ago

[e.me][bug] Long press on pinned cloud apps doesn't toggle edit mode

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Everything.me
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ranbena, Assigned: amirn)

References

Details

(Keywords: regression, Whiteboard: burirun1, burirun2 [NO_UPLIFT])

Attachments

(2 files)

Patch - redirect to github PR
233 bytes, text/html
crdlc
: review+
Details
12534.html
210 bytes, text/html
crdlc
: review+
Details 
Long pressing any pinned app should toggle edit mode.
Assignee: nobody → amirn
Blocks: 910316
Status: NEW → ASSIGNED
blocking-b2g: --- → koi?

        Attachment #800099 -
        Flags: review?(crdlc)

    
    

    
  
Comment on attachment 800099 [details]
Patch - redirect to github PR

Good job, thanks

        Attachment #800099 -
        Flags: review?(crdlc) → review+

    
    

    
  
Landed in master
https://github.com/mozilla-b2g/gaia/commit/552587d0802c0a582fdb487201bb70e3ce4af359
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
Vivien asked to revert all recent v1.2 commits.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
Just making a note that this appears to be backed out here: https://github.com/mozilla-b2g/gaia/commit/83c9c656955611bc28205511050ed6cb5ad7b4e5
Whiteboard: burirun1
Keywords: regression

    
  
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED

    
    

    
  
Added to stg-pr branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  

      
      
      
      

        Attached file
          
        12534.html
        — 
      

    


  
This PR is only a rebase to master

        Attachment #811713 -
        Flags: review?(crdlc)

        Attachment #811713 -
        Flags: review?(crdlc) → review+

    
    

    
  
Set obsolete patches

    
    

    
  
landed in master
https://github.com/mozilla-b2g/gaia/commit/f1cdfdd322fdd94a5fffcba8483f284f82d23e3c
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+

    
  
Whiteboard: burirun1 → burirun1, burirun2

    
    

    
  
I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 f1cdfdd322fdd94a5fffcba8483f284f82d23e3c
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(amirn)

    
    

    
  
Per a recent release drivers discussion, we need to hold off on uplifting this to 1.2 until we confirm a path forward post the planned e.me 1.2 status meeting tomorrow.
Whiteboard: burirun1, burirun2 → burirun1, burirun2 [NO_UPLIFT]

    
    

    
  
removing koi? since e.me 1.2 features are delayed for future version
blocking-b2g: koi+ → ---
Flags: needinfo?(amirn)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: