[e.me][bug] Homescreen cloud app icon is wrong size

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ranbena, Assigned: evyatar)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Save a cloud app to the Homescreen.
It's size is 60x60 instead of 58x58 which is a grid icons standard size.
Created attachment 802918 [details]
2013-09-11-12-03-59.png

even after pulling the icons up through the search, you will find that icons pixelated.
Naoki what you're describing is related to https://bugzilla.mozilla.org/show_bug.cgi?id=915145
This ticket is only about icon size.
Oh.  Thanks.

Updated

5 years ago
Flags: needinfo?(evyatar)
Ran - since most of the icons rendering methods have since changes, is this still relevant?
Flags: needinfo?(evyatar) → needinfo?(ran)
Yes, still relevant.
Flags: needinfo?(ran)
Created attachment 8341735 [details] [review]
Patch - redirect to github PR
Attachment #8341735 - Flags: review?(ran)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Attachment #8341735 - Flags: review?(amirn)

Comment 7

5 years ago
Comment on attachment 8341735 [details] [review]
Patch - redirect to github PR

looks good! (added screenshot, left: before change, right: after)
small comment on Github
Attachment #8341735 - Flags: review?(amirn) → review+

Comment 8

5 years ago
Created attachment 8342349 [details]
left: before change, right: after
Notice the icon is still 60x60 when bookmarking from the (e.me) browser chrome.
Fixed comment 9 about bookmarking from inside e.me browser.
landed on master
449b9324ed97c7954aece44c99446658d08eb960

https://github.com/mozilla-b2g/gaia/commit/449b9324ed97c7954aece44c99446658d08eb960
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8341735 [details] [review]
Patch - redirect to github PR

(I approved before landing. For some reason didn't take..)
Attachment #8341735 - Flags: review?(ran) → review+

Updated

5 years ago
Assignee: nobody → evyatar
You need to log in before you can comment on or make changes to this bug.