Implement a module to validate the app manifest

RESOLVED FIXED in Firefox 26

Status

()

Firefox
Developer Tools: WebIDE
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

unspecified
Firefox 26
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

5 years ago
We need a module to help the developer figuring out various kind of error that can happen around its app manifest like bad JSON, wrong property values or missing files...
(Assignee)

Comment 1

5 years ago
Created attachment 798558 [details] [diff] [review]
Implement a module to validate the app manifest
(Assignee)

Updated

5 years ago
Attachment #798558 - Flags: review?(paul)

Comment 2

5 years ago
Comment on attachment 798558 [details] [diff] [review]
Implement a module to validate the app manifest

Let's not have errors messages hidden in the code.

Can you use a .properties file. I'm not saying we should get them localized, but I'd rather have these messages all listed in one file.
Attachment #798558 - Flags: review?(paul) → review-

Updated

5 years ago
Blocks: 912447

Updated

5 years ago
Blocks: 912913
(Assignee)

Comment 3

5 years ago
Created attachment 800062 [details] [diff] [review]
Use l10n properties file for strings
Attachment #798558 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
Created attachment 800068 [details] [diff] [review]
Use l10n properties file for strings
Attachment #800062 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #800068 - Flags: review?(paul)

Updated

5 years ago
Attachment #800068 - Flags: review?(paul) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 800111 [details] [diff] [review]
Fix duplicated key and unnecessary message when package app folder do not have manifest file

Interdiff to fix issues...
Attachment #800068 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
Created attachment 800112 [details] [diff] [review]
Implement a module to validate the app manifest

Final patch to land
(Assignee)

Comment 7

5 years ago
Comment on attachment 800112 [details] [diff] [review]
Implement a module to validate the app manifest

See previous patch for interdiff.
Attachment #800112 - Flags: review?(paul)

Updated

5 years ago
Attachment #800112 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/b92cf59aa9d7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Comment on attachment 800112 [details] [diff] [review]
Implement a module to validate the app manifest

Review of attachment 800112 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/devtools/app-manager.properties
@@ +12,5 @@
> +validator.wrongManifestFileName=Packaged apps require a manifest file that can only be named 'manifest.webapp' at project root folder
> +validator.invalidManifestURL=Invalid manifest URL '%S'
> +validator.invalidManifestJSON=The webapp manifest isn't a valid JSON file: %1$S at: %2$S
> +validator.noAccessManifestURL=Unable to read manifest file: %1$S at: %2$S
> +validator.invalidHostedManifestURL=Invalid hosted manifest URL '%1$S': %2$S

l10n comments would definitely help for these 3 strings.

@@ +16,5 @@
> +validator.invalidHostedManifestURL=Invalid hosted manifest URL '%1$S': %2$S
> +validator.invalidProjectType=Unknown project type '%S'
> +validator.missNameManifestProperty=Missing mandatory 'name' in Manifest.
> +validator.missIconsManifestProperty=Missing 'icons' in Manifest.
> +validator.missIconForMarketplace=app submission to the Marketplace needs at least an 128 icon

Is "an 128 icon" correct in English?
You need to log in before you can comment on or make changes to this bug.