911817 - error on localized geo-location info pages

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[[:philipp]]

Attachment: screenshot

when a user visits a non en-US version of https://www.mozilla.org/firefox/geolocation/, like for example https://www.mozilla.org/de/firefox/geolocation/ the following error message will show up after a short amount of time with no particular action required by the user:

"Google has disabled use of the Maps API for this application. The provided key is not a valid Google API Key, or it is not authorized for the Google Maps Javascript API v2 on this site. If you are the owner of this application, you can learn about obtaining a valid key here: http://code.google.com/apis/maps/documentation/javascript/v2/introduction.html#Obtaining_Key"

Comment 1

[Pascal Chevrel:pascalc]

The English page is now powered by Bedrock and the Google maps API key was recently updated there. Our localized pages are still sent from our older framework and the Google Maps key wasn't updated there. The right fix is to port these pages to bedrock buyt I don't have time for that for now. The short term fix would proibably be that an admin updates the API key on the server on the php side.

Comment 2

[Jennifer Bertsch [:jbertsch]]

Cmore: thoughts?

Comment 4

[Hector Zhao [:hectorz]]

Attachment: Patch

This is the same patch as https://github.com/mozilla/bedrock/commit/c17f9c8e, just for the php site, which is used by localized (legacy) /firefox/geolocation.

Comment 5

[Alex Gibson [:agibson]]

Comment on attachment 805747 [details] [diff] [review]
Patch

Review of attachment 805747 [details] [diff] [review]:
-----------------------------------------------------------------

The JS here works as intended and has in large, already been reviewed when updated on bedrock - so r+ there. I did have some trouble applying this patch however (not quite sure why, perhaps a line ending thing - but I get errors?). In the end I had to copy/paste in the new code to test it. 

Maybe someone with more svn know-how can take a look at applying the patch to push it?

Comment 6

[Paul [:pmac] McLanahan]

Committed to trunk in r119981.

Comment 7

[Paul [:pmac] McLanahan]

Merged to prod in r119992.

Comment 8

[raymond [:retornam] (inactive)]

verified fixed https://www.mozilla.org/de/firefox/geolocation/