Closed
Bug 911829
Opened 11 years ago
Closed 11 years ago
Separate main thread and worker cycle collector telemetry
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: smaug, Assigned: mccr8)
Details
Attachments
(1 file)
8.09 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Do we end up reporting worker results as CYCLE_COLLECTOR? That could lead to the odd drop in CC times in telemetry.
Reporter | ||
Comment 1•11 years ago
|
||
...since I doubt we've managed to speed up CC so that median CC time is 0ms.
Assignee | ||
Comment 2•11 years ago
|
||
Yeah, I was realizing that just the other day. The easy fix would just be to add an IsMainThread() check, and report separate telemetry for worker cycle collection times.
Ah, yes. We should probably have separate telemetry tags for main thread/worker thread.
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → continuation
Assignee | ||
Updated•11 years ago
|
Summary: CYCLE_COLLECTOR telemetry reports look odd → Separate main thread and worker cycle collector telemetry
Assignee | ||
Comment 4•11 years ago
|
||
Reporter | ||
Updated•11 years ago
|
Attachment #801917 -
Flags: review+
Assignee | ||
Comment 5•11 years ago
|
||
try run: https://tbpl.mozilla.org/?tree=Try&rev=760c1d1023c0
Assignee | ||
Comment 6•11 years ago
|
||
I tested locally and it seemed to work. https://hg.mozilla.org/integration/mozilla-inbound/rev/a90d8624e03d
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a90d8624e03d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•