911850 - BindBufferRange should check for out-of-bounds range

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Let BindBufferRange check the range

... rather than trusting the underlying GL to get it right.

Comment 1

[Guillaume Abadie]

Oups... good catch! =D

Comment 2

[Kelsey Gilbert [:jgilbert] (previously Jeff)]

Comment on attachment 798634 [details] [diff] [review]
Let BindBufferRange check the range

Review of attachment 798634 [details] [diff] [review]:
-----------------------------------------------------------------

Nit.

::: content/canvas/src/WebGLContextBuffers.cpp
@@ +113,5 @@
>          } else if (target != buffer->Target()) {
>              return ErrorInvalidOperation("bindBuffer: buffer already bound to a different target");
>          }
> +        CheckedInt<WebGLsizeiptr> checked_neededByteLength = CheckedInt<WebGLsizeiptr>(offset) + size;
> +        if (!checked_neededByteLength.isValid() || checked_neededByteLength.value() > buffer->ByteLength()) {

Can we put these two conditions on separate lines?

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49daf6b00b8f

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/49daf6b00b8f