Closed
Bug 911853
Opened 11 years ago
Closed 11 years ago
OpenGL types should be explicit-size integer types
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: bjacob, Assigned: bjacob)
References
Details
Attachments
(1 file)
|
1.54 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
GLint is defined as an integer type of at least 32bit (and of course, in practice, exactly 32bit). So int32_t is a better match than int. In practice, it doesn't matter much, but we could eventually have a platform where int's are 64bit and there, we'd probably still want GLint to be 32bit. Fixing this is also a prereq to discarding redundant WebGL typedefs, see dependent bug.
Attachment #798637 -
Flags: review?(jgilbert)
|
||
Updated•11 years ago
|
Attachment #798637 -
Attachment is patch: true
|
|
||
Updated•11 years ago
|
Attachment #798637 -
Flags: review?(jgilbert) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/104a75d724dd
Assignee: nobody → bjacob
Target Milestone: --- → mozilla26
https://hg.mozilla.org/mozilla-central/rev/104a75d724dd
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•