911856 - Remove the custom concept of "stable context" in favor of the standard concept of "lost context"

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Remove the "context stable" terminology, switch everything to IsContextLoss

IsContextLost immediately evocates the standard concept of a "lost context".

IsContextStable... is not so clear. Stable could mean many different things.

Anyway we should not have two concepts that only differ from each other by being each other's contrary.

Plus, most uses of IsContextStable were preceded by a negation operator (!) so this change removes many negations.

Note that this patch renames the ContextStable enum value by ContextNotLost. Ugly, but very rarely used as such, and means exactly what it means.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc6759deb5e1

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc6759deb5e1