Closed Bug 911879 Opened 6 years ago Closed 6 years ago

Give WebGLContext.h a good round of removing unneeded inline method bodies

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: bjacob, Assigned: bjacob)

Details

Attachments

(1 file)

Note in particular:
 - many of the WebGL entry points were moved to WebGLContext.h during the switch to new DOM bindings. For many of them, that wasn't really needed or useful.
 - some of the WebGL entry points taking DOM elements (like TexImage2D) are templated. Those are nontrivial to take out of the header. Left in for now.
 - created a new file, WebGLContextLossTimer.cpp, for that stuff.
 - one method was substantially modified: UpdateWebGLErrorAndClearGLError. It used to have 2 signatures, one taking an output pointer param to get the error code. Changed to one signature with optional argument.
Attachment #798671 - Flags: review?(jgilbert)
Comment on attachment 798671 [details] [diff] [review]
Give WebGLContext.h a good round of removing unneeded inline method bodies

Review of attachment 798671 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContext.h
@@ +198,5 @@
>  
>      void DummyFramebufferOperation(const char *info);
>  
> +    WebGLTexture *activeBoundTextureForTarget(GLenum target) const {
> +      return target == LOCAL_GL_TEXTURE_2D ? mBound2DTextures[mActiveTexture]

You two-space'd this indent on accident.
Attachment #798671 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8a27424be7f
Assignee: nobody → bjacob
Target Milestone: --- → mozilla26
https://hg.mozilla.org/mozilla-central/rev/b8a27424be7f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.