911895 - [WAP push] If press home button while reading wap push message, sender number and close button of the message are still on top blocking original notification bar.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Enpei]

Attachment: 13:33, 9/3.

After receive wap push message and open it, pressing home button can still see the sender number and close button of the message on top of the page, which also block original notification bar.

* Build Number                
Gaia:     9fb5802df60a9081846d704def01df814ed8fbd4
Gecko:    http://hg.mozilla.org/mozilla-central/rev/b6c29e434519
BuildID   20130901040215
Version   26.0a1

* Reproduce Steps

* Expected Result

* Actual Result

* Occurrence rate

Comment 1

[Enpei]

Attachment: video

Comment 2

[Enpei]

* Reproduce Steps
1. Send a Wap push to DUT(via NowSMS)
2. open the message.
3. Press home key.

* Expected Result
Wap push message will hide the notification bar.

* Actual Result
sender number and close button remain on top of the page blocking notification bar.

* Occurrence rate
100%

Comment 3

[Gabriele Svelto [:gsvelto]]

Attachment: [PULL REQUEST] Close the WAP Push attention screen when the home button is pressed

Pointer to Github pull-request

Comment 4

[Gabriele Svelto [:gsvelto]]

Attachment: [PATCH] Close the WAP Push attention screen when the home button is pressed

This patch detects when the attention screen is shrunk into the status-bar (which happens when the home button is pressed) and closes it instead. The patch also ensures that the entire application closes itself when the attention screen is dismissed.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 802367 [details] [diff] [review]
[PATCH] Close the WAP Push attention screen when the home button is pressed

Review of attachment 802367 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/wappush/js/wappush.js
@@ +119,4 @@
>     * @param {Number} timestamp The message timestamp
>     */
>    displayWapPushMessage: function wpm_displayWapPushMessage(timestamp) {
> +    var self = this;

Let's declare that closer to where it is used.

@@ +156,5 @@
> +   * Closes the application, lets the event loop run once to ensure clean
> +   * termination of pending events.
> +   */
> +  close: function wpm_close() {
> +    window.setTimeout(function() { window.close(); }, 0);

nit: Some tends to omit the last parameter for this use case. It ends up beeing |window.setTimeout(window.close);|.

Comment 6

[Gabriele Svelto [:gsvelto]]

Merci :-)

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #5)
> Let's declare that closer to where it is used.

OK, I'll move it below.

> nit: Some tends to omit the last parameter for this use case. It ends up
> beeing |window.setTimeout(window.close);|.

Thanks for the tip. My C background always tells me to write out stuff explicitly :-)

Comment 7

[Gabriele Svelto [:gsvelto]]

Attachment: [PATCH v2] Close the WAP Push attention screen when the home button is pressed

Updated patch, r=vingtetun as per comment 5. I changed the |close()| function but couldn't move forward the declaration of |self| in |wpd_displayWapPushMessage()| because everything below it is just a big closure.

Comment 8

[Gabriele Svelto [:gsvelto]]

Merged to master: https://github.com/mozilla-b2g/gaia/commit/256ec63034c0083c92d595d5eca1e2f3dc1eca13

Comment 9

[Enpei]

Verified on Buri
Gaia:     9ffd2899eb91388f7fc1ce6f7a895a6f5f922c05
Gecko:    http://hg.mozilla.org/mozilla-central/rev/a98569f21abe
BuildID   20130912040201
Version   26.0a1