Closed Bug 911914 Opened 10 years ago Closed 10 years ago

Cannot build BionicGlue.cpp with --enable-android-libstdcxx

Categories

(Core :: mozglue, defect)

Product:
Core
Component:
mozglue
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

fix
1.11 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
When using gcc 4.8 with --enable-android-libstdcxx, the following error occurs.


/home/makoto/Development/hg.mozilla.org/mobile/mozglue/build/BionicGlue.cpp: In function 'pid_t __wrap_fork()':
/home/makoto/Development/hg.mozilla.org/mobile/mozglue/build/BionicGlue.cpp:113:63: error: conversion from 'std::vector<AtForkFuncs, SpecialAllocator<AtForkFuncs> >::iterator {aka __gnu_cxx::__normal_iterator<AtForkFuncs*, std::vector<AtForkFuncs, SpecialAllocator<AtForkFuncs> > >}' to non-scalar type 'std::vector<AtForkFuncs>::iterator {aka __gnu_cxx::__normal_iterator<AtForkFuncs*, std::vector<AtForkFuncs> >}' requested
     for (std::vector<AtForkFuncs>::iterator it = atfork.begin();
                                                               ^
/home/makoto/Development/hg.mozilla.org/mobile/mozglue/build/BionicGlue.cpp:114:13: error: no match for 'operator<' (operand types are 'std::vector<AtForkFuncs>::iterator {aka __gnu_cxx::__normal_iterator<AtForkFuncs*, std::vector<AtForkFuncs> >}' and 'std::vector<AtForkFuncs, SpecialAllocator<AtForkFuncs> >::iterator {aka __gnu_cxx::__normal_iterator<AtForkFuncs*, std::vector<AtForkFuncs, SpecialAllocator<AtForkFuncs> > >}')
          it < atfork.end(); ++it)
Attached patch fix — — Splinter Review 

        Attachment #798724 -
        Flags: review?(mh+mozilla)

        Attachment #798724 -
        Flags: review?(mh+mozilla) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/60147d584aad
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.