Closed Bug 91197 Opened 23 years ago Closed 23 years ago

talkback top-crash where |GetReadableFragment| is called on strings with no buffers...

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: scc, Assigned: scc)

References

Details

(Keywords: crash, topcrash)

Attachments

(2 files)

fix busted |GetXXXFragment| routines, _and_ don't even call them when I don't need to
18.10 KB, patch
Details | Diff | Splinter Review
(informational only) same patch as above, but ignoring space changes for ease of reading
11.34 KB, patch
Details | Diff | Splinter Review 
...it used to be an invariant that all strings had buffers, even if empty.  This
was relaxed recently, and must be dealt with accordingly.
The fixes above make |GetXXXFragment| not crash when there is no buffer, but
also circumvent general logic when |IsEmpty()| makes that possible.
Status: NEW → ASSIGNED
Severity: normal → critical
Keywords: crash, topcrash
What topcrash(es) did this cause?  We might want it on the branch.
*** Bug 91281 has been marked as a duplicate of this bug. ***
The last talkback report for the stack trace nsAFlatCString::GetReadableFragment
was on build 2001082809 on the trunk.  It's not showing up on any topcrash
reports for N610, N620, trunk, or M094

Marking fixed.  Reopen as needed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Component: String → XPCOM
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: