Closed Bug 911978 Opened 8 years ago Closed 8 years ago

If no contacts are present export should be disabled

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 affected)

RESOLVED FIXED
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- affected

People

(Reporter: jmcf, Assigned: jmcf)

Details

(Whiteboard: [u=commsapps-user c=contacts p=0])

Attachments

(1 file)

Currently there is an strange behaviour when no contacts are present and the user clicks on the export button. 

Solution: Disable the export button if contact list is empty
blocking-b2g: --- → koi?
Whiteboard: [u=commsapps-user c=contacts p=0]
Attached file 12030.html
Attachment #801518 - Flags: review?(francisco.jordano)
Hi,

there is a weird case that we are dont have contact, we import contacts from any source and then, despite that we do have contacts, the export functionality will be still disabled.

For that we will need to listen to the oncontactschange in the settings.js file.

I know that is over complicating a simple and well defined patch. Noemi, can we live without this?

Thanks!
good catch Francisco!

Fortunately it has an easy fix!
Comment on attachment 801518 [details]
12030.html

\o/ now we are talking. This is 'canela fina'.

Thanks a lot for the work Jose!
Attachment #801518 - Flags: review?(francisco.jordano) → review+
https://github.com/mozilla-b2g/gaia/commit/67c20c1e250ef327b2253349fdd7e9dda14f1f40
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+
You need to log in before you can comment on or make changes to this bug.