If no contacts are present export should be disabled

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jmcf, Assigned: jmcf)

Tracking

unspecified
x86
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 affected)

Details

(Whiteboard: [u=commsapps-user c=contacts p=0])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Currently there is an strange behaviour when no contacts are present and the user clicks on the export button. 

Solution: Disable the export button if contact list is empty
(Assignee)

Updated

5 years ago
blocking-b2g: --- → koi?
Whiteboard: [u=commsapps-user c=contacts p=0]
(Assignee)

Comment 1

5 years ago
Created attachment 801518 [details]
12030.html
Attachment #801518 - Flags: review?(francisco.jordano)
Hi,

there is a weird case that we are dont have contact, we import contacts from any source and then, despite that we do have contacts, the export functionality will be still disabled.

For that we will need to listen to the oncontactschange in the settings.js file.

I know that is over complicating a simple and well defined patch. Noemi, can we live without this?

Thanks!
(Assignee)

Comment 3

5 years ago
good catch Francisco!

Fortunately it has an easy fix!
Comment on attachment 801518 [details]
12030.html

\o/ now we are talking. This is 'canela fina'.

Thanks a lot for the work Jose!
Attachment #801518 - Flags: review?(francisco.jordano) → review+
(Assignee)

Comment 5

5 years ago
https://github.com/mozilla-b2g/gaia/commit/67c20c1e250ef327b2253349fdd7e9dda14f1f40
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+
status-b2g-v1.2: --- → affected
You need to log in before you can comment on or make changes to this bug.