911978 - If no contacts are present export should be disabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

Currently there is an strange behaviour when no contacts are present and the user clicks on the export button. 

Solution: Disable the export button if contact list is empty

Comment 1

[Jose Manuel Cantera]

Attachment: 12030.html

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

there is a weird case that we are dont have contact, we import contacts from any source and then, despite that we do have contacts, the export functionality will be still disabled.

For that we will need to listen to the oncontactschange in the settings.js file.

I know that is over complicating a simple and well defined patch. Noemi, can we live without this?

Thanks!

Comment 3

[Jose Manuel Cantera]

good catch Francisco!

Fortunately it has an easy fix!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 801518 [details]
12030.html

\o/ now we are talking. This is 'canela fina'.

Thanks a lot for the work Jose!

Comment 5

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/67c20c1e250ef327b2253349fdd7e9dda14f1f40