912011 - colors in front page graph don't match headers below

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Kaiser]

I guess since the fix of bug 884944 (which fixed this for /daily) or so, the colors on the front page now do not match the headers below it. You can easily see that by comparing the front page with /daily or by realizing that the line that only has data for the few days back is the current beta, but its color doesn't match the header of the beta mentioned below.

This should be fixed and probably a legend added there as well, the same way it was done for /daily.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

This is rather ugly I was wondering why FxA trunk was so crashy. Turns out that the colors or labels are mixed up.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Attachment: Screenshot suggesting FxA 23 has 10 crashes per 100 ADU

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Attachment: Screenshot showing FxA 26 has 10 crashes per 100 ADU

Comment 4

[Laura Thomson :laura]

Peter: can you get this done this week or so?

Comment 5

[Peter Bengtsson [:peterbe]]

Pull request: https://github.com/mozilla/socorro/pull/1483

Comment 6

[Peter Bengtsson [:peterbe]]

Steps to reproduce:

1. Load the home page
2. The 4 Firefox versions loaded in the graph should have a legend in the upper right-hand corner
3. The colors of the versions (in the legend) should match the 4 versions list (from left to right) underneath the graph

4. Now load the "Crashes per User" report (aka Daily)
5. The same 4 colors should match the versions on the home page graph
6. The table in the bottom should match the same colors as the home page. 
7. The most recent version should be to the left out of the 4 versions.

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/3890db472ed26737ef19f200c130f4e9f9d77508
fixes bug 912011 - colors in front page graph don't match headers below

https://github.com/mozilla/socorro/commit/27296435f2592219ceddf19690aca347471ce67f
Merge pull request #1483 from peterbe/bug-912011-colors-in-front-page-graph-dont-match-headers-below

fixes bug 912011 - colors in front page graph don't match headers below

Comment 8

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on stage

QA verified on stage - many thanks :peterbe for outlining the changes present in the bug fix - comment 6.

https://crash-stats.allizom.org/home/products/Firefox#duration=14

https://crash-stats.allizom.org/daily?form_selection=by_version&p=Firefox&v=26.0a1&v=25.0a2&v=24.0b&v=23.0.1&hang_type=any&os=Windows&os=Mac+OS+X&os=Linux&date_range_type=report&date_start=2013-08-27&date_end=2013-09-10&submit=Generate

- ADIs matched: /daily?=Firefox and /home/products/Firefox#duration=14
- legend and graph colors match when /daily?=Firefox and /home/products/Firefox#duration=14 are compared
-  Ordering of versions is such that the most recent version is to the left and version #'s are in descending order (LtR)