956 bytes, patch
|Details | Diff | Splinter Review|
The message "xmlencoding detect- ISO-8859-1" (or whatever charset) is being printed with each page load in release builds. This needs to be turned off, and really should be turned off in the 0.9.2/RTM branch (i.e., I don't really care about this being in trunk builds, but end users don't need to see this kind of stuff).
Created attachment 42628 [details] [diff] [review] Patch (or whatever variation that cuts out the naked printf).
Just to note (not that harishd and vidur don't know this), but this landed as part of the fix for PDT+ bug 81253.
Yikes. We should fix this.
Fixed on the trunk.
We couldn't get a PDT approval on this. Removing nsBranch and marking fixed.
Just noting that per bug 76720, this was a priority for an embedded customer: To quote the manager-formerly-known-as-phil: "My must-have is no console output (or memory use from redirected output) on Linux optimized builds." Personally, I don't care, but it seems that adding '//' before the printf to satisfy this embedding customer is pretty high in reward-to-risk terms.
I am told that marek may wish to take this on the branch post 6.1. Marek?
Moving to more realistic target - m0.9.4!
Fixed on the branch
Verified fixed checked in cvs (rev 3.257)