912053 - ReferenceError in XHR handling

Status: RESOLVED FIXED

(L20n :: HTML Bindings, defect)

Description

[mik01aj]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1588.0 Safari/537.36

Steps to reproduce:

I don't know. Perhaps I pressed stop in my browser.

But the issue is, that there is a piece of code like this:

xhr.addEventListener('abort', function(e) {
   callback(ex);
 });


Actual results:

It thrown a ReferenceError


Expected results:

I think that there should be "ex" instead of "e". Looks like a simple bug to fix.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: 912053.patch

great catch! Thank you!

Attaching a patch proposal. Michal, can you take a look?

Comment 2

[Michał Gołębiowski-Owczarek [:mgol]]

(In reply to Zbigniew Braniecki [:gandalf] from comment #1)
> Created attachment 799607 [details] [diff] [review]
> 912053.patch
> 
> great catch! Thank you!
> 
> Attaching a patch proposal. Michal, can you take a look?

Should be good. :)

Comment 3

[Michał Gołębiowski-Owczarek [:mgol]]

Comment on attachment 799607 [details] [diff] [review]
912053.patch

Review of attachment 799607 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine for me. Thanks!

Comment 4

[Michał Gołębiowski-Owczarek [:mgol]]

Sorry for the comment mess, I don't know how to mark an attachment as reviewed here (I haven't contributed a lot of patches/etc. on Bugzilla so far).

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

https://github.com/l20n/l20n.js/commit/85c29d6333a5cad4f2130dae33d37ebcebe566f7

thanks guys!