Open Bug 912054 Opened 11 years ago Updated 2 years ago

don't re-initialize mBoundRect in nsRegion::Init

Categories

(Core :: Graphics, defect)

defect

Tracking

()

REOPENED

People

(Reporter: froydnj, Unassigned)

References

Details

Attachments

(1 file)

      No description provided.
mBoundRect is automatically initialized with zero members through nsBaseRect, so
we don't need to redo work.

I added the assertions in case some clever person ever comes along and wants to
use Init() from someplace other than the constructors Init() is currently (and
only) called from.  I don't feel particularly strongly about them, so feel free
to suggest nixing them if you like.
Attachment #798869 - Flags: review?(bgirard)
Attachment #798869 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/2255560d9b6c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Depends on: 913251
We are considering backing this out in bug 913251 because it caused permanent Windows PGO linker errors on the UX branch which means Nightlies are broken. Since the Nighlies are really useful for regression finding and performance tracking, we need a way to fix the builds. If you have other ideas, please let us know.
Assignee: nobody → nfroyd
Flags: needinfo?(nfroyd)
We confirmed in bug 913251 that backing this patch out fixes PGO so we're going to go ahead with backing this out once my m-c update is done. Nathan is on PTO today and BenWa was fine with this.
Backed out: https://hg.mozilla.org/mozilla-central/rev/62ac395d5f0b
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla26 → ---
Flags: needinfo?(nfroyd)

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Assignee: froydnj+bz → nobody
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: