Created attachment 798869 [details] [diff] [review] don't re-initialize mBoundRect in nsRegion::Init mBoundRect is automatically initialized with zero members through nsBaseRect, so we don't need to redo work. I added the assertions in case some clever person ever comes along and wants to use Init() from someplace other than the constructors Init() is currently (and only) called from. I don't feel particularly strongly about them, so feel free to suggest nixing them if you like.
Attachment #798869 - Flags: review?(bgirard)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
We are considering backing this out in bug 913251 because it caused permanent Windows PGO linker errors on the UX branch which means Nightlies are broken. Since the Nighlies are really useful for regression finding and performance tracking, we need a way to fix the builds. If you have other ideas, please let us know.
Assignee: nobody → nfroyd
We confirmed in bug 913251 that backing this patch out fixes PGO so we're going to go ahead with backing this out once my m-c update is done. Nathan is on PTO today and BenWa was fine with this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla26 → ---
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago → 3 days ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.