912091 - The notification button is missing

Status: RESOLVED WONTFIX

(Firefox Graveyard :: SocialAPI, defect)

Description

[Simona Badau, Desktop Test Engineering]

Attachment: the notification button on Windows 8.

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130903030201

On the latest Nightly 26.0a1, the notification button is missing.

Steps to reproduce:
1. Launch Firefox 26.0a1 with a new profile.
2. Navigate to http://mixedpuppy.github.io/socialapi-demo/
3. Click on the Activate The Demo Provider.

Expected results:
The notification button is placed on the URL bar between the "Share This Page" button and the "Demo Social Service" button. Clicking the button allows you to share data on your computer for off-line
mode and to share your location.

Actual results:
The notification button is missing on Windows 8 (please see the attached screenshot for more details).
On Mac OS X and Ubuntu 13.04 - a Geolocation button is placed on the URL bar between the "Share This Page" button and the "Demo Social Service" button and there is no indication of the notification: This website (http://mixedpuppy.github.io) is asking to store data on your computer for off-line use. The button is also different, as if the option to allow sharing data on your computer was already selected.

Notes:
The issue is not reproducible on Firefox 24 beta 8 nor on the latest Aurora 25.0a2.

Comment 1

[u279076]

Please find a regression window.

Comment 2

[Shane Caraveo (:mixedpuppy)]

WFM on osx 10.7 in 
fx26 as of 08-27 and 09-03
fx25 as of 09-02

Comment 3

[Simona Badau, Desktop Test Engineering]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #1)
> Please find a regression window.

I might have been not clear enough in the Description - on Firefox 24 beta 8 I see an "i" button, and when the button is clicked, the following notifications are seen in the panel:
- This website (http://mixedpuppy.github.io) is asking to store data on your computer for off-line use
- Would you like to share your location with http://mixedpuppy.github.io?

On Windows 8 (tried on 2 different machines), the notification button is completely missing (please keep in mind that on Windows 7, Ubuntu and Mac OS X I still get a "geolocation" button with a geolocation notification - but there is no sign of the first notification mentioned in the above paragraph).

On Windows 8 I found 2 situations:

1. the "i" button with the store data notification started missing since July 17th - the "gelocation" button and notification are still available.

Last good nightly: 2013-08-16
First bad nightly: 2013-08-17

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1ed5a88cd4d0&tochange=8ad1e4c838c8

- this behavior is also reproducible for all the other platforms: Windows 7, Ubuntu 13.04 and Mac OS X.

2. the "geolocation" button and notification are also missing starting August 31:

Last good nightly: 2013-08-30
First bad nightly: 2013-08-31

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c7459bc8e449&tochange=4ba8dda1ee31

- this behavior is NOT reproducible for all the other platforms: Windows 7, Ubuntu 13.04 and Mac OS X.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Something I just noticed on my latest build of nightly, the offline permissions do not happen immediately when I initially install the demo provider.  It took a while for it to appear in the panel, and the icon does not change in that circumstance (not a big deal.  If I then reload the provider both are requested immediately and the info icon is used.  I added bug 913530 for this.  Can you verify whether this is the issue you are seeing when you only get the geo icon?


just a couple notes:  

The info icon is used where there is more than one notification at the same time.  Otherwise, the icon specific to the notification is used.  This is why the geolocation button is showing per the last comment.  Something is causing the offline notification to be skipped.

I am not concerned about offline apps not working in social right now, as long as media requests (video/mic) in the chat windows works, so the level of severity for this bug would be based around that.  The demo provider has a button that will initiate a get media request in order to show the media permissions panel.

@markh: are you able to reproduce on windows?

Comment 5

[Mark Hammond [:markh] [:mhammond]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
> @markh: are you able to reproduce on windows?

I'm not sure :)  What I see on Windows is a bit of a mess and seems to have a number of problems - I'm not sure if any of them are the same as reported here or not!  I opened bug 913989.

Comment 6

[Simona Badau, Desktop Test Engineering]

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
> Something I just noticed on my latest build of nightly, the offline
> permissions do not happen immediately when I initially install the demo
> provider.  It took a while for it to appear in the panel, and the icon does
> not change in that circumstance (not a big deal.  If I then reload the
> provider both are requested immediately and the info icon is used.  I added
> bug 913530 for this.  Can you verify whether this is the issue you are
> seeing when you only get the geo icon?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130909030204
I don't get the offline permission no matter what I do (close/reopen Firefox, sing in/out the service, reload the worker, enable/disable the service). Tried on Ubuntu 13.04 and Mac OS X 10.9 (waited for several minutes).

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Shane - currently tracking this for FF26 but it's not assigned to anyone, is this going to be in your work queue?

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

from IRC we're going to get a refreshed look at whether this is still reproducing and what next steps are.

Comment 9

[u279076]

Attachment: Screenshot - Windows 8 Notifications

I think this is less about icons not appearing and more about notifications not being sent (as illustrated in my screenshot and explained below).

Firefox 26.0a1 2013-08-16:
> Services Activated notification appears
> Offline Storage notification appears
> Geolocation notification appears 
> Notification icon appears

Firefox 26.0a1 2013-08-17:
> Services Activated notification appears
> Geolocation icon appears
> Geolocation notification appears

Firefox 26.0a1 2013-08-31:
> Services Activated notification appears

The first regression is in Firefox 26.0a1 2013-08-17 where the notification icon stops displaying, but that's a red herring. The (i) icon is only supposed to appear when we have multiple notifications to display. Since there's only one notification (geolocation) that's the icon you see. The real problem here is that we have stopped getting the "Offline Storage" notification.

The second regression is in Firefox 26.0a1 2013-08-31 where the geolocation icon stops displaying for the same reason, we don't get the notification anymore.

In a nutshell, I think we have two separate regressions here:
1) Offline Storage notifications for Social Providers stopped working in Firefox 26.0a1 2013-08-17
2) Geolocation notifications for Social Providers stopped working in Firefox 26.0a1 2013-08-31

Comment 10

[u279076]

FWIW, I can also reproduce this on Windows XP and Fedora 19 so I don't think this is a Windows 8-only issue.

Comment 11

[Shane Caraveo (:mixedpuppy)]

Offline storage notification was changed in bug 892488, however does not check the site-specific setting which is bug 933993.

I'm am able to repro the failure to get a geolocation notification on win7, but not on osx.

Comment 12

[Shane Caraveo (:mixedpuppy)]

geolocation permission seems to work in my dev build on win7

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

At this point we're too late for speculative fixes and it's looking like we'll need to wontfix here. Shane is this something we should continue to track for FF27 and beyond? If so, please nominate for tracking.

Comment 14

[Shane Caraveo (:mixedpuppy)]

The button in question is removed from fx 29 and on.  Permissions for the social sidebar now hang off a sidebar header.  Whether we reintroduce the specific icons again depends on actual usage in the wild (IMO) since most of the permissions work was done to support talkilla.  The chat window video/voice permissions icon works well enough for that.