Closed Bug 912108 Opened 6 years ago Closed 6 years ago

Rename BinaryData to TypedObject

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: nmatsakis, Assigned: nmatsakis)

References

Details

Attachments

(1 file)

Binary Data has been renamed to Typed Objects:

http://wiki.ecmascript.org/doku.php?id=harmony:typed_objects
Assignee: general → nmatsakis
Blocks: 898349
Depends on: 910777
Attached patch Bug912108.diffSplinter Review
Attachment #798957 - Flags: review?(sphink)
Comment on attachment 798957 [details] [diff] [review]
Bug912108.diff

Review of attachment 798957 [details] [diff] [review]:
-----------------------------------------------------------------

I read every single line of this patch. Twice. It was riveting.

At least one of the statements above is false.

If you increment the numeric value found in the previous sentence, it will not affect the overall sentence's veracity.
Attachment #798957 - Flags: review?(sphink) → review+
Comment on attachment 798957 [details] [diff] [review]
Bug912108.diff

> diff --git a/js/src/builtin/BinaryData.cpp b/js/src/builtin/BinaryData.cpp
> deleted file mode 100644
> index 3ce7273..0000000
> --- a/js/src/builtin/BinaryData.cpp
> +++ /dev/null
> diff --git a/js/src/builtin/TypedObject.cpp b/js/src/builtin/TypedObject.cpp
> new file mode 100644
> index 0000000..26ac3f2
> --- /dev/null
> +++ b/js/src/builtin/TypedObject.cpp

Why did you drop all histories instead of using hg mv? (I can hardly believe the reviewer didn't point it out.)
(In reply to Masatoshi Kimura [:emk] from comment #3)
> Comment on attachment 798957 [details] [diff] [review]
> Bug912108.diff
> 
> Why did you drop all histories instead of using hg mv? (I can hardly believe
> the reviewer didn't point it out.)

Oh. Heh. I assumed that was just splinter being dumb, and didn't look at the actual patch. Yeah, these should be renames.
Good point. The answer is that I used `git mv`, and that's how the patch came out. I'll make sure to use `hg mv` when I actually push the work.
To clarify, I mean that I do my work on git, not hg, and then I generally just move patches as needed.
https://hg.mozilla.org/mozilla-central/rev/55d63d4b07e2
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.