912178 - Soft-deleted apps cause 'My Apps' page to load with 'Oops, something went wrong' error message

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Install an app and make sure it is listed under My Apps page
2. Soft delete that app
3. Load 'My apps' page again

expected behavior:
My Apps page loads just fine (may be, we disable the install button for the deleted app?)

observed behavior:

My apps page loads with 'Oops..something went wrong' since the app 404s. See http://cl.ly/image/1Y1f3E3K0c3n

Comment 1

[Mathieu Pillard [:mat]]

Err, so, here is the code we are using in the API for this resource:

    def obj_get_list(self, request=None, **kwargs):
        return Webapp.uncached.filter(installed__user=request.amo_user,
                                     installed__install_type=INSTALL_TYPE_USER)

And... here is how Webapp.uncached behaves : https://gist.github.com/diox/963cb5e9ed6ee7d8e11e

Evidently something is very very wrong here, and I bet it affects a lot of other things...

Comment 2

[Kevin Ngo [:ngoke]]

We can override the uncached manager from the Addon model to exclude soft-deleted ones. The uncached manager doesn't look like it knows about our Addon manager.

Comment 3

[Mathieu Pillard [:mat]]

My plain is to completely remove the uncached manager and use no_cache() queryset method everywhere, to fix it once and for all for every model. See bug 913010 for details

Comment 4

[Mathieu Pillard [:mat]]

Should be fixed by https://github.com/mozilla/zamboni/commit/b179bd0b539c92c6bee48ccfa377b047473ecab5

Please test on -dev and report back, thanks.

Comment 5

[krupa raj[:krupa]]

I deleted one of the apps listed at My Apps and loaded the page again and it seemed to work without any issues.

Comment 6

[Victor Carciu]

I tried the same scenario and everything worked as expected. I will mark it as verified .