Closed Bug 912183 Opened 11 years ago Closed 11 years ago

context menu shows all possible options when only feed accounts are set up

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird24-, thunderbird25 fixed, thunderbird26 fixed, thunderbird_esr2425+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 27.0
Tracking Flags:
Tracking Status
thunderbird24 - ---
thunderbird25 --- fixed
thunderbird26 --- fixed
thunderbird_esr24 25+ fixed

People

(Reporter: aryx, Assigned: mkmelin)

Details

Attachments

(2 files)

screenshot of issue
10.58 KB, image/png
Details
proposed fix
1.07 KB, patch
standard8
: review+
standard8
: approval-comm-aurora+
standard8
: approval-comm-beta+
standard8
: approval-comm-esr24+
Details | Diff | Splinter Review
Attached image screenshot of issue —
Thunderbird 24.0b2 (20130828132738) on Windows XP SP3 I created a new profile, launched it, added some feed accounts, subscribed to some feeds. Now I get the following context menu for a message (see screenshot), containing many separators and an 'Add to Dictionary' menu item.
Anything in the error console?
Nothing in the error console. Dupe to bug 887010 which needs workaround?
This happens in a profile which has only feed accounts. It seems like gFolderDisplay.canArchiveSelectedMessages fails in http://mxr.mozilla.org/comm-beta/source/mail/base/content/nsContextMenu.js#296 This fails because getIdentityForHeader is null http://mxr.mozilla.org/comm-beta/source/mail/base/content/folderDisplay.js#2059 So http://mxr.mozilla.org/comm-beta/source/mail/base/content/mailCommands.js has not been loaded yet.
If it only happens with feed-only account TB then I'm not worried about this for TB 24, though obviously it'd be great to have a fix.
tracking-thunderbird24: ? → -
OS: Windows XP → All
Hardware: x86 → All
Summary: 'Add to Dictionary' and many horizontal separators/lines in context menu for message → context menu shows all possible options when only feed accounts are set up
Attached patch proposed fix — — Splinter Review
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #808212 - Flags: review?(mbanner)
Comment on attachment 808212 [details] [diff] [review] proposed fix Looks good, thanks.
Attachment #808212 - Flags: review?(mbanner) → review+
Pushed to trunk to get landed for branches: https://hg.mozilla.org/comm-central/rev/289b7a3d60ad
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 27.0
Attachment #808212 - Flags: approval-comm-esr24?
Attachment #808212 - Flags: approval-comm-beta+
Attachment #808212 - Flags: approval-comm-aurora+
Attachment #808212 - Flags: approval-comm-esr24? → approval-comm-esr24+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: