912251 - Implement `Client#screenshot`

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Mike Pennisi [:jugglinmike]]

Implement the `screenshot` method according to the Python API documentation [1]:

> Marionette.screenshot(element=None, highlights=None)
> Creates a base64-encoded screenshot of the element, or the current frame if no element is specified.
> Parameters:	
>  element – The element to take a screenshot of. If None, will take a screenshot of the current frame.
>  highlights – A list of HTMLElement objects to draw a red box around in the returned screenshot.

[1] https://marionette_client.readthedocs.org/en/latest/#marionette.Marionette.screenshot

Comment 1

[Mike Pennisi [:jugglinmike]]

Attachment: 912251-screenshot.patch

This is a work-in-progress patch. I won't be able to fully verify its correctness until Bug 912244 lands.

Comment 2

[Mike Pennisi [:jugglinmike]]

I've created Bug 912611 in order to isolate the aspect of this work that is blocked by bug 912244. This will allow us to land the basic screenshot functionality in the JavaScript client in advance of the `highlights` work propagating downstream.

Comment 3

[Mike Pennisi [:jugglinmike]]

Attachment: 912251-screenshot-v2.patch

I've also submitted this patch as a pull request on GitHub:

https://github.com/mozilla-b2g/marionette-js-client/pull/53

Comment 4

[James Lal [:lightsofapollo]]

Comment on attachment 799678 [details] [diff] [review]
912251-screenshot-v2.patch

one nit- see github... Can you also release a new feature version and update the HISTORY.md (in a different commit).

Comment 5

[Mike Pennisi [:jugglinmike]]

master: https://github.com/mozilla-b2g/marionette-js-client/commit/d34c3e2bac16f43da0b507b51ff44d3bca4cee43

Incorporated James' feedback and released v0.14.0. Thanks, James!