Closed Bug 912285 Opened 11 years ago Closed 6 years ago

[mozprocess] ProcessHandler should front-end more subprocess API

Categories

(Testing :: Mozbase, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: k0scist, Unassigned)

References

Details

Functionality needed for mochitest runtests.py.  See
https://bugzilla.mozilla.org/show_bug.cgi?id=746243

- [mozprocess] ProcessHandler.run()
  should return the PID
  https://github.com/mozilla/mozbase/blob/master/mozprocess/mozprocess/processhandler.py#L535

- [mozprocess] self.pid should return 'None' before process start and
  after process finish

- [mozprocess] ProcessHandler should add .poll(),
  .terminate() (and/or .send_signal())
  http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#114
  http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#116

Note that reimplementing ProcessHandler as a subclass of
subprocess.Popen -- bug 819547 -- takes care of the above
The blocker is loose as it can be worked around.  If desired, I can break this up into multiple bugs, but the overall code change will be small.
Blocks: 746243
Note also that if we need legacy compatability (which we will) we can preserve a wrapper around the new API complete wth deprecation warnings.
Mass closing bugs with no activity in 2+ years. If this bug is important to you, please re-open.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.