Closed
Bug 912302
Opened 9 years ago
Closed 9 years ago
Slim down TraceLogging output by shortening entry keys and timestamps
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: till, Assigned: till)
Details
Attachments
(1 file)
4.48 KB,
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
This patch shortens all names for the various entries to one or two letters. Additionally, the TraceLogging constructor now takes a timestamp and substracts that from all later timestamps, shortening them quite a bit. Corresponding changes to generate.py coming in a pull request.
Attachment #799197 -
Flags: review?(hv1989)
Assignee | ||
Comment 2•9 years ago
|
||
Oh, and I forgot to mention: this reduces log file size by about 25%.
Comment 3•9 years ago
|
||
Comment on attachment 799197 [details] [diff] [review] Slim down TraceLogging output by shortening entry keys and timestamps Review of attachment 799197 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/TraceLogging.cpp @@ +80,5 @@ > + "0,ps", // stop script parsing > + "1,pl", // start lazy parsing > + "0,pl", // stop lazy parsing > + "1,pf", // start Function parsing > + "0,pf", // stop Function parsing lowercase function @@ +83,5 @@ > + "1,pf", // start Function parsing > + "0,pf", // stop Function parsing > + "e,i", // engine interpreter > + "e,b", // engine baseline > + "e,j" // engine IonMonkey lowercase ionmonkey Why do interpreter and ionmonkey start both with an i. Maybe we should use "o"? i = interpreter b = baseline engine o = optimizing engine (ionmonkey) @@ +89,5 @@ > TraceLogging* TraceLogging::_defaultLogger = NULL; > > TraceLogging::TraceLogging() > : loggingTime(0), > + startupTime(rdtsc()), nice
Attachment #799197 -
Flags: review?(hv1989) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 799197 [details] [diff] [review] Slim down TraceLogging output by shortening entry keys and timestamps Review of attachment 799197 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/TraceLogging.cpp @@ +80,5 @@ > + "0,ps", // stop script parsing > + "1,pl", // start lazy parsing > + "0,pl", // stop lazy parsing > + "1,pf", // start Function parsing > + "0,pf", // stop Function parsing Isn't this for parsing triggered by using `new Function("bla")`? In that case, lowercase function would be somewhat misleading, I think. @@ +83,5 @@ > + "1,pf", // start Function parsing > + "0,pf", // stop Function parsing > + "e,i", // engine interpreter > + "e,b", // engine baseline > + "e,j" // engine IonMonkey It's actually a "j", not an "i", but I like "o" much, much better.
Comment 5•9 years ago
|
||
(In reply to Till Schneidereit [:till] from comment #4) > Comment on attachment 799197 [details] [diff] [review] > Slim down TraceLogging output by shortening entry keys and timestamps > > Review of attachment 799197 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: js/src/TraceLogging.cpp > @@ +80,5 @@ > > + "0,ps", // stop script parsing > > + "1,pl", // start lazy parsing > > + "0,pl", // stop lazy parsing > > + "1,pf", // start Function parsing > > + "0,pf", // stop Function parsing > > Isn't this for parsing triggered by using `new Function("bla")`? In that > case, lowercase function would be somewhat misleading, I think. Makes sense.
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb1d06db46eb
https://hg.mozilla.org/mozilla-central/rev/bb1d06db46eb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•