Closed
Bug 912338
Opened 11 years ago
Closed 11 years ago
[mozprofile] Profile.pop_preferences() has wrongly hardcoded user.js
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
References
Details
Attachments
(1 file)
|
964 bytes,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
https://github.com/mozilla/mozbase/blob/master/mozprofile/mozprofile/profile.py#L202 Clearly this should be filename. This results in cleanup going into an infinite loop in `clean_preferences`. I had noticed this before but hadn't tracked down the issue until now.
|
Reporter | |
Comment 1•11 years ago
|
||
Attachment #799273 -
Flags: review?(wlachance)
|
|
Reporter | |
Comment 2•11 years ago
|
||
There's all sorts of other issues in this functions but I'm looking for a quick fix.
|
||
Comment 3•11 years ago
|
||
Comment on attachment 799273 [details] [diff] [review] bug-912338.diff Review of attachment 799273 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #799273 -
Flags: review?(wlachance) → review+
|
|
Reporter | |
Comment 4•11 years ago
|
||
pushed: https://github.com/mozilla/mozbase/commit/97ffebb7629fb2076d545c36528b7be86e04beff Thanks
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•