912347 - stop showing the protocolHandlerRegistered door hanger.

Status: RESOLVED FIXED

(Firefox :: File Handling, defect)

Description

[Doug Turner (:dougt)]

Attachment: Screen Shot 2013-09-03 at 9.47.21 PM.png

Every time a webapp re-registers a protocol handler that is already registered, there is an info bar that displays:

%S has already been added as an application for %S links.

I am not sure why we do this, but it is pretty annoying.  Re-registering should be silent.

Comment 1

[Doug Turner (:dougt)]

myk, do you mind if I remove this?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

I don't mind!  And I agree.  This message is particularly confusing because it appears *before* the user is prompted to approve the registration; so it can easily come out of the blue, with no context to explain why it appeared:

  https://github.com/mozilla/mozilla-central/blob/f194714a1daafa4fe4ba0a211cf63e9e21f319e9/browser/components/feeds/src/WebContentConverter.js#L412-L416

And nothing in the spec requires or even suggests such a message:

  http://www.whatwg.org/specs/web-apps/current-work/#custom-handlers

However, I'm neither the owner nor a peer of the module in question (Firefox).  Let's see what Gavin thinks.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

no objection!

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(https://bugzilla.mozilla.org/show_bug.cgi?id=372441#c10 and https://bugzilla.mozilla.org/show_bug.cgi?id=372441#c13 don't have any rationale, unfortunately)

Comment 5

[Doug Turner (:dougt)]

Attachment: bug_912347_prevent_already_registered_protocol_handler_info_bar

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 800813 [details] [diff] [review]
bug_912347_prevent_already_registered_protocol_handler_info_bar

Review of attachment 800813 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/feeds/src/WebContentConverter.js
@@ +412,5 @@
>        // XXX this should be a "security exception" according to spec
>        throw("Not allowed to register a protocol handler for " + aProtocol);
>      }
>  
> +    var buttons;

I should remove this.

Comment 8

[Doug Turner (:dougt)]

review ping?

Comment 9

[Doug Turner (:dougt)]

Comment on attachment 800813 [details] [diff] [review]
bug_912347_prevent_already_registered_protocol_handler_info_bar

over to jaws -- his queue looks empty.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 800813 [details] [diff] [review]
bug_912347_prevent_already_registered_protocol_handler_info_bar

Review of attachment 800813 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/feeds/src/WebContentConverter.js
@@ +420,4 @@
>  
> +    var notificationIcon = uri.prePath + "/favicon.ico";
> +    var notificationValue = "Protocol Registration: " + aProtocol;
> +    var addButton = {

Remove the |var buttons = [addButton];| below and just change this to be:
var buttons = [{
 ...
}];
since addButton isn't used elsewhere.

Comment 11

[Doug Turner (:dougt)]

https://hg.mozilla.org/mozilla-central/rev/a4e9c9c9dbf9