Closed Bug 912386 Opened 7 years ago Closed 7 years ago

[e.me][bug] Long press cloud result in Search also opens it

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ranbena, Assigned: evyatar)

References

Details

(Whiteboard: [NO_UPLIFT])

Attachments

(2 files)

STR:
1. Search for any query
2. Long press a cloud app

Expected: A confirmation prompt opens
Actual: A confirmation prompt opens, AND app opens in the bg.
Assignee: nobody → evyatar
Blocks: 910316
Status: NEW → ASSIGNED
fixed. branch *bugfix-apps-hold-click*

Commit 66c697d637137f6d1cf29a9890dc66fa558ffba8
https://github.com/EverythingMe/gaia/commit/66c697d637137f6d1cf29a9890dc66fa558ffba8
Attachment #800085 - Flags: review?(crdlc)
Comment on attachment 800085 [details]
Patch - redirect to github PR

Just a comment, good work!
Attachment #800085 - Flags: review?(crdlc) → review+
blocking-b2g: --- → koi?
Landed in master
https://github.com/mozilla-b2g/gaia/commit/c39e4700d3218775c876d858817ec76cfc18d5e6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Just making a note that this appears to be backed out here: https://github.com/mozilla-b2g/gaia/commit/c9e9a31ae4fe9d85bc2eccfdc823b2f7f2aa6cd9
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Added to stg-pr branch
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file redirect to PR
This PR is only a rebase to master
Attachment #811707 - Flags: review?(crdlc)
Attachment #811707 - Flags: review?(crdlc) → review+
landed in master
https://github.com/mozilla-b2g/gaia/commit/e7c011371aa6af696033d4b867fb9152a6985efa
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+
I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 e7c011371aa6af696033d4b867fb9152a6985efa
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(evyatar)
Per a recent release drivers discussion, we need to hold off on uplifting this to 1.2 until we confirm a path forward post the planned e.me 1.2 status meeting tomorrow.
Whiteboard: [NO_UPLIFT]
Clearing nom - we're no longer taking e.me 1.2 feature changes to 1.2.
blocking-b2g: koi+ → ---
Flags: needinfo?(evyatar)
You need to log in before you can comment on or make changes to this bug.