912386 - [e.me][bug] Long press cloud result in Search also opens it

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

STR:
1. Search for any query
2. Long press a cloud app

Expected: A confirmation prompt opens
Actual: A confirmation prompt opens, AND app opens in the bg.

Comment 1

[Evyatar 'Tron' Amitay (everything.me)]

fixed. branch *bugfix-apps-hold-click*

Commit 66c697d637137f6d1cf29a9890dc66fa558ffba8
https://github.com/EverythingMe/gaia/commit/66c697d637137f6d1cf29a9890dc66fa558ffba8

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Patch - redirect to github PR

Comment 3

[Cristian Rodriguez (:crdlc)]

Comment on attachment 800085 [details]
Patch - redirect to github PR

Just a comment, good work!

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Landed in master
https://github.com/mozilla-b2g/gaia/commit/c39e4700d3218775c876d858817ec76cfc18d5e6

Comment 5

[Kevin Grandon :kgrandon]

Just making a note that this appears to be backed out here: https://github.com/mozilla-b2g/gaia/commit/c9e9a31ae4fe9d85bc2eccfdc823b2f7f2aa6cd9

Comment 6

[Amir Nissim (:amirn)]

Added to stg-pr branch

Comment 7

[Amir Nissim (:amirn)]

Attachment: redirect to PR

This PR is only a rebase to master

Comment 8

[Amir Nissim (:amirn)]

landed in master
https://github.com/mozilla-b2g/gaia/commit/e7c011371aa6af696033d4b867fb9152a6985efa

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 e7c011371aa6af696033d4b867fb9152a6985efa
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 10

[Jason Smith [:jsmith]]

Per a recent release drivers discussion, we need to hold off on uplifting this to 1.2 until we confirm a path forward post the planned e.me 1.2 status meeting tomorrow.

Comment 11

[Jason Smith [:jsmith]]

Clearing nom - we're no longer taking e.me 1.2 feature changes to 1.2.