Closed Bug 912388 Opened 12 years ago Closed 12 years ago

The overlay doesn't show up when all video are unplayable video with flash new install.

Categories

(Firefox OS Graveyard :: Gaia::Video, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: johnhu, Assigned: arasbm)

Details

Attachments

(2 files)

The empty overlay should be shown when no playable video in Video app. Symptom: the overlay doesn't show up. STR: 1. delete all video with video app and close it. 2. delete mediadb through adb shell or use make reset-gaia 3. put unplayable video file into storage 4. open video app Expected: The empty overlay shows. Actual: All black but two buttons.
Attached image screenshot
As to sample video, please create an empty file with ".3gp" extension.
The step to delete mediadb through adb shell: 1. adb shell ls /data/local/indexedDB/ 2. find out the folder with video in its name 3. adb shell rm -r /data/local/indexedDB/{folder-name}
More explanation about "empty" overlay: The "empty" overlay is the overlay shows "Add videos to get started", see /apps/video/locales/video.en-US.properties for more information.
I can work on this issue. Feel free to assign this bug to me. Thanks!
Thanks, Aras.
Assignee: nobody → arasbm
Attached file PR.html
John Hu, After lots of testing, this is the solution I came up with. Look forward to your review and comments.
Attachment #801212 - Flags: review?(johu)
Attachment #801212 - Attachment mime type: text/plain → text/html
Comment on attachment 801212 [details] PR.html Cool, Aras. This patch looks look. It's the correct position to update the dialog. Thanks for the patch. r=me. I will help to change the status of this bug and land the code.
Attachment #801212 - Flags: review?(johu) → review+
Sorry, there is a typo => This patch looks good.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: