912388 - The overlay doesn't show up when all video are unplayable video with flash new install.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

The empty overlay should be shown when no playable video in Video app.

Symptom: the overlay doesn't show up.
STR:
   1. delete all video with video app and close it.
   2. delete mediadb through adb shell or use make reset-gaia
   3. put unplayable video file into storage
   4. open video app

Expected:
   The empty overlay shows.

Actual:
   All black but two buttons.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: screenshot

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

As to sample video, please create an empty file with ".3gp" extension.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

The step to delete mediadb through adb shell:
1. adb shell ls /data/local/indexedDB/
2. find out the folder with video in its name
3. adb shell rm -r /data/local/indexedDB/{folder-name}

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

More explanation about "empty" overlay:

The "empty" overlay is the overlay shows "Add videos to get started", see /apps/video/locales/video.en-US.properties for more information.

Comment 5

[Aras Balali Moghaddam]

I can work on this issue. Feel free to assign this bug to me. Thanks!

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Thanks, Aras.

Comment 7

[Aras Balali Moghaddam]

Attachment: PR.html

John Hu,
After lots of testing, this is the solution I came up with. Look forward to your review and comments.

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 801212 [details]
PR.html

Cool, Aras. This patch looks look. It's the correct position to update the dialog. Thanks for the patch. r=me.

I will help to change the status of this bug and land the code.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Sorry, there is a typo => This patch looks good.

Comment 10

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master

https://github.com/mozilla-b2g/gaia/commit/ab52c3d9c7e57b9c3fe8c82e79786be85f320277