Closed
Bug 912388
Opened 12 years ago
Closed 12 years ago
The overlay doesn't show up when all video are unplayable video with flash new install.
Categories
(Firefox OS Graveyard :: Gaia::Video, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: arasbm)
Details
Attachments
(2 files)
The empty overlay should be shown when no playable video in Video app.
Symptom: the overlay doesn't show up.
STR:
1. delete all video with video app and close it.
2. delete mediadb through adb shell or use make reset-gaia
3. put unplayable video file into storage
4. open video app
Expected:
The empty overlay shows.
Actual:
All black but two buttons.
Reporter | ||
Comment 1•12 years ago
|
||
Reporter | ||
Comment 2•12 years ago
|
||
As to sample video, please create an empty file with ".3gp" extension.
Reporter | ||
Comment 3•12 years ago
|
||
The step to delete mediadb through adb shell:
1. adb shell ls /data/local/indexedDB/
2. find out the folder with video in its name
3. adb shell rm -r /data/local/indexedDB/{folder-name}
Reporter | ||
Comment 4•12 years ago
|
||
More explanation about "empty" overlay:
The "empty" overlay is the overlay shows "Add videos to get started", see /apps/video/locales/video.en-US.properties for more information.
Assignee | ||
Comment 5•12 years ago
|
||
I can work on this issue. Feel free to assign this bug to me. Thanks!
Assignee | ||
Comment 7•12 years ago
|
||
John Hu,
After lots of testing, this is the solution I came up with. Look forward to your review and comments.
Attachment #801212 -
Flags: review?(johu)
Assignee | ||
Updated•12 years ago
|
Attachment #801212 -
Attachment mime type: text/plain → text/html
Reporter | ||
Comment 8•12 years ago
|
||
Comment on attachment 801212 [details]
PR.html
Cool, Aras. This patch looks look. It's the correct position to update the dialog. Thanks for the patch. r=me.
I will help to change the status of this bug and land the code.
Attachment #801212 -
Flags: review?(johu) → review+
Reporter | ||
Comment 9•12 years ago
|
||
Sorry, there is a typo => This patch looks good.
Reporter | ||
Comment 10•12 years ago
|
||
merged to master
https://github.com/mozilla-b2g/gaia/commit/ab52c3d9c7e57b9c3fe8c82e79786be85f320277
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•